LHSmicius
commented
1 year ago Bot!
Closed LHSmicius closed 1 year ago
LHSmicius
commented
1 year ago Bot!
github-actions[bot]
commented
1 year ago This review is brought to you by the Horizon EDA Poolbot commit 33131f8.
| State | Type | Name | Checks | Version | Filename |
|---|---|---|---|---|---|
| New | Part | DMP610DL | :heavy_check_mark: Pass | 0 :heavy_check_mark: | parts/transistor/pmos/DMP610DL.json |
Bold items are from this PR
Bold items are from this PR
Values in italic are inherited
| MPN | Value | Manufacturer | Datasheet | Description | Tags |
|---|---|---|---|---|---|
| DMP610DL | Diodes Inc. | https://www.diodes.com/assets/Datasheets/DMP610DL.pdf | P-channel MOSFET, -60V, -180mA, 10Ω | mosfet p-channel smd transistor |
Inerhits from DMP3099L
:heavy_check_mark: Checks passed
| Attribute | Value |
|---|---|
| MPN | DMP610DL |
| Value | (inherited) |
| Manufacturer | Diodes Inc. (38 other parts) (inherited) |
| Datasheet | https://www.diodes.com/assets/Datasheets/DMP610DL.pdf |
| Description | P-channel MOSFET, -60V, -180mA, 10Ω |
| Tags | mosfet p-channel smd transistor (inherited) |
Orderable MPNs
RX14
commented
1 year ago Is it right to inherit from other similar part which is not a base part
You should create a new base part for "sot-23 p-channel mosfet" and then set that as the base part for both parts. Then it matches up with how the rest of the pool is done.
LHSmicius
commented
1 year ago Bot!
Made base part "base sot-23 P-channel MOSFET" Changed base part for DMP610DL Add base part for DMP3099L
github-actions[bot]
commented
1 year ago This review is brought to you by the Horizon EDA Poolbot commit 33131f8.
| State | Type | Name | Checks | Version | Filename |
|---|---|---|---|---|---|
| Modified | Part | DMP3099L | :heavy_check_mark: Pass | 0 :heavy_check_mark: | parts/transistor/pmos/DMP3099L.json |
| New | Part | DMP610DL | :heavy_check_mark: Pass | 0 :heavy_check_mark: | parts/transistor/pmos/DMP610DL.json |
| New | Part | base sot-23 P-channel MOSFET | :heavy_check_mark: Pass | 1 :heavy_check_mark: | parts/transistor/pmos/base-sot-23.json |
| Status | File |
|---|---|
| Modified | parts/transistor/pmos/DMP3099L.json |
Bold items are from this PR
Bold items are from this PR
Values in italic are inherited
| MPN | Value | Manufacturer | Datasheet | Description | Tags |
|---|---|---|---|---|---|
| base sot-23 P-channel MOSFET | base P-channel MOSFET, SOT-23 | mosfet p-channel smd transistor | |||
| DMP610DL | Diodes Inc. | https://www.diodes.com/assets/Datasheets/DMP610DL.pdf | P-channel MOSFET, -60V, -180mA, 10Ω | mosfet p-channel smd transistor | |
| DMP3099L | Diodes Inc. | https://www.diodes.com/assets/Datasheets/DMP3099L.pdf | P-channel MOSFET, -30V, -3.8A, 65mΩ | mosfet p-channel smd transistor |
:heavy_check_mark: Checks passed
| Attribute | Value |
|---|---|
| MPN | base sot-23 P-channel MOSFET |
| Value | |
| Manufacturer | (124 other parts) |
| Datasheet | |
| Description | base P-channel MOSFET, SOT-23 |
| Tags | mosfet p-channel smd transistor |
Flags
| Pad | Gate | Pin |
|---|---|---|
| 1 | Main | G |
| 2 | Main | S |
| 3 | Main | D |
Inerhits from base sot-23 P-channel MOSFET
:heavy_check_mark: Checks passed
| Attribute | Value |
|---|---|
| MPN | DMP610DL |
| Value | |
| Manufacturer | Diodes Inc. (38 other parts) |
| Datasheet | https://www.diodes.com/assets/Datasheets/DMP610DL.pdf |
| Description | P-channel MOSFET, -60V, -180mA, 10Ω |
| Tags | mosfet p-channel smd transistor (inherited) |
Orderable MPNs
Inerhits from base sot-23 P-channel MOSFET
:heavy_check_mark: Checks passed
| Attribute | Value |
|---|---|
| MPN | DMP3099L |
| Value | |
| Manufacturer | Diodes Inc. (38 other parts) |
| Datasheet | https://www.diodes.com/assets/Datasheets/DMP3099L.pdf |
| Description | P-channel MOSFET, -30V, -3.8A, 65mΩ |
| Tags | mosfet p-channel smd transistor (inherited) |
Orderable MPNs
RX14
commented
1 year ago Looks good to me, thanks for the contribution!
Bot! As always I have a question. Is it right to inherit from other similar part which is not a base part? Here I made DMP610DL mosfet which inherits from DMP3099L. These have much in common except electrical characteristics.