Open alex-fu27 opened 1 year ago
Okay, I think I fixed the originial issues. I also changed the QFP32 package to a generic one that I generated using the wizard.
Bot!
This review is brought to you by the Horizon EDA Poolbot commit 33131f8.
State | Type | Name | Checks | Version | Filename |
---|---|---|---|---|---|
New | Entity | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | entities/ic/mcu/microchip/ATmega328P-AU.json |
New | Package | QFP32 | :warning: Warn | 0 :heavy_check_mark: | packages/ic/smd/qfp/QFP32/package.json |
New | Part | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | parts/ic/mcu/microchip/ATmega328P-AU.json |
New | Symbol | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | symbols/ic/mcu/microchip/ATmega328P-AU.json |
New | Unit | ATmega328P-AU | :heavy_check_mark: Pass | 1 :x: (>0) | units/ic/mcu/microchip/ATmega328P-AU.json |
Bold items are from this PR
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
MPN | ATmega328P-AU |
Value | |
Manufacturer | Microchip (15 other parts) |
Datasheet | http://ww1.microchip.com/downloads/en/DeviceDoc/ATmega48A-PA-88A-PA-168A-PA-328-P-DS-DS40002061A.pdf |
Description | AVR 32KiB Flash 2KiB SRAM 2.5V/3.3V/5V 32-Pin TQFP |
Tags | avr mcu |
Pad | Gate | Pin |
---|---|---|
1 | Main | PD3 |
2 | Main | PD4 |
3 | Main | GND |
4 | Main | VCC |
5 | Main | GND |
6 | Main | VCC |
7 | Main | PB6 |
8 | Main | PB7 |
9 | Main | PD5 |
10 | Main | PD6 |
11 | Main | PD7 |
12 | Main | PB0 |
13 | Main | PB1 |
14 | Main | PB2 |
15 | Main | PB3 |
16 | Main | PB4 |
17 | Main | PB5 |
18 | Main | AVCC |
19 | Main | ADC6 |
20 | Main | AREF |
21 | Main | GND |
22 | Main | ADC7 |
23 | Main | PC0 |
24 | Main | PC1 |
25 | Main | PC2 |
26 | Main | PC3 |
27 | Main | PC4 |
28 | Main | PC5 |
29 | Main | PC6 |
30 | Main | PD0 |
31 | Main | PD1 |
32 | Main | PD2 |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | Microchip (15 other parts) |
Prefix | U |
Tags | avr mcu |
Gate | Suffix | Swap group | Unit |
---|---|---|---|
Main | 0 | ATmega328P-AU |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | Microchip (15 other parts) |
Pin | Direction | Alternate names |
---|---|---|
ADC6 | Input | |
ADC7 | Input | |
AREF | Input | |
AVCC | Power Input | |
GND | Power Input | |
PB0 | Bidirectional | ICP1 (NC), PCINT0 (NC), CLKO (NC) |
PB1 | Bidirectional | PCINT1 (BiDi), OC1A (BiDi) |
PB2 | Bidirectional | PCINT2 (BiDi), OC1B (BiDi) |
PB3 | Bidirectional | MOSI (BiDi), PCINT3 (BiDi), OC2A (BiDi) |
PB4 | Bidirectional | PCINT4 (BiDi), MISO (BiDi) |
PB5 | Bidirectional | SCK (BiDi), PCINT5 (BiDi) |
PB6 | Bidirectional | TOSC1 (PIn), PCINT6 (PIn), XTAL1 (PIn) |
PB7 | Bidirectional | TOSC2 (BiDi), PCINT7 (BiDi), XTAL2 (BiDi) |
PC0 | Bidirectional | ADC0 (BiDi), PCINT8 (BiDi) |
PC1 | Bidirectional | ADC1 (BiDi), PCINT9 (BiDi) |
PC2 | Bidirectional | ADC2 (BiDi), PCINT10 (BiDi) |
PC3 | Bidirectional | ADC3 (BiDi), PCINT11 (BiDi) |
PC4 | Bidirectional | PCINT12 (BiDi), ADC4 (BiDi), SDA (BiDi) |
PC5 | Bidirectional | PCINT13 (BiDi), ADC5 (BiDi), SCL (BiDi) |
PC6 | Bidirectional | RESET (BiDi), PCINT14 (BiDi) |
PD0 | Bidirectional | RXD (BiDi), PCINT16 (BiDi) |
PD1 | Bidirectional | TXD (BiDi), PCINT17 (BiDi) |
PD2 | Bidirectional | INT0 (BiDi), PCINT18 (BiDi) |
PD3 | Bidirectional | INT1 (BiDi), PCINT19 (BiDi), OC2B (BiDi) |
PD4 | Bidirectional | T0 (BiDi), PCINT20 (BiDi), XCK (BiDi) |
PD5 | Bidirectional | T1 (PIn), PCINT21 (PIn), OC0B (PIn) |
PD6 | Bidirectional | AIN0 (BiDi), PCINT22 (BiDi), OC0A (BiDi) |
PD7 | Bidirectional | PCINT23 (OC), AIN1 (OC) |
VCC | Power Input |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | (124 other parts) |
Tags | generic ic qfp smd |
Package checks didn't pass
:heavy_check_mark: Clearance checks passed
aaah haven't used Horizon for a while and forgot the parameter program
Bot!
This review is brought to you by the Horizon EDA Poolbot commit 33131f8.
State | Type | Name | Checks | Version | Filename |
---|---|---|---|---|---|
New | Entity | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | entities/ic/mcu/microchip/ATmega328P-AU.json |
New | Package | QFP32 | :heavy_check_mark: Pass | 0 :heavy_check_mark: | packages/ic/smd/qfp/QFP32/package.json |
New | Part | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | parts/ic/mcu/microchip/ATmega328P-AU.json |
New | Symbol | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | symbols/ic/mcu/microchip/ATmega328P-AU.json |
New | Unit | ATmega328P-AU | :heavy_check_mark: Pass | 1 :x: (>0) | units/ic/mcu/microchip/ATmega328P-AU.json |
Bold items are from this PR
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
MPN | ATmega328P-AU |
Value | |
Manufacturer | Microchip (15 other parts) |
Datasheet | http://ww1.microchip.com/downloads/en/DeviceDoc/ATmega48A-PA-88A-PA-168A-PA-328-P-DS-DS40002061A.pdf |
Description | AVR 32KiB Flash 2KiB SRAM 2.5V/3.3V/5V 32-Pin TQFP |
Tags | avr mcu |
Pad | Gate | Pin |
---|---|---|
1 | Main | PD3 |
2 | Main | PD4 |
3 | Main | GND |
4 | Main | VCC |
5 | Main | GND |
6 | Main | VCC |
7 | Main | PB6 |
8 | Main | PB7 |
9 | Main | PD5 |
10 | Main | PD6 |
11 | Main | PD7 |
12 | Main | PB0 |
13 | Main | PB1 |
14 | Main | PB2 |
15 | Main | PB3 |
16 | Main | PB4 |
17 | Main | PB5 |
18 | Main | AVCC |
19 | Main | ADC6 |
20 | Main | AREF |
21 | Main | GND |
22 | Main | ADC7 |
23 | Main | PC0 |
24 | Main | PC1 |
25 | Main | PC2 |
26 | Main | PC3 |
27 | Main | PC4 |
28 | Main | PC5 |
29 | Main | PC6 |
30 | Main | PD0 |
31 | Main | PD1 |
32 | Main | PD2 |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | Microchip (15 other parts) |
Prefix | U |
Tags | avr mcu |
Gate | Suffix | Swap group | Unit |
---|---|---|---|
Main | 0 | ATmega328P-AU |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | Microchip (15 other parts) |
Pin | Direction | Alternate names |
---|---|---|
ADC6 | Input | |
ADC7 | Input | |
AREF | Input | |
AVCC | Power Input | |
GND | Power Input | |
PB0 | Bidirectional | ICP1 (NC), PCINT0 (NC), CLKO (NC) |
PB1 | Bidirectional | PCINT1 (BiDi), OC1A (BiDi) |
PB2 | Bidirectional | PCINT2 (BiDi), OC1B (BiDi) |
PB3 | Bidirectional | MOSI (BiDi), PCINT3 (BiDi), OC2A (BiDi) |
PB4 | Bidirectional | PCINT4 (BiDi), MISO (BiDi) |
PB5 | Bidirectional | SCK (BiDi), PCINT5 (BiDi) |
PB6 | Bidirectional | TOSC1 (PIn), PCINT6 (PIn), XTAL1 (PIn) |
PB7 | Bidirectional | TOSC2 (BiDi), PCINT7 (BiDi), XTAL2 (BiDi) |
PC0 | Bidirectional | ADC0 (BiDi), PCINT8 (BiDi) |
PC1 | Bidirectional | ADC1 (BiDi), PCINT9 (BiDi) |
PC2 | Bidirectional | ADC2 (BiDi), PCINT10 (BiDi) |
PC3 | Bidirectional | ADC3 (BiDi), PCINT11 (BiDi) |
PC4 | Bidirectional | PCINT12 (BiDi), ADC4 (BiDi), SDA (BiDi) |
PC5 | Bidirectional | PCINT13 (BiDi), ADC5 (BiDi), SCL (BiDi) |
PC6 | Bidirectional | RESET (BiDi), PCINT14 (BiDi) |
PD0 | Bidirectional | RXD (BiDi), PCINT16 (BiDi) |
PD1 | Bidirectional | TXD (BiDi), PCINT17 (BiDi) |
PD2 | Bidirectional | INT0 (BiDi), PCINT18 (BiDi) |
PD3 | Bidirectional | INT1 (BiDi), PCINT19 (BiDi), OC2B (BiDi) |
PD4 | Bidirectional | T0 (BiDi), PCINT20 (BiDi), XCK (BiDi) |
PD5 | Bidirectional | T1 (PIn), PCINT21 (PIn), OC0B (PIn) |
PD6 | Bidirectional | AIN0 (BiDi), PCINT22 (BiDi), OC0A (BiDi) |
PD7 | Bidirectional | PCINT23 (OC), AIN1 (OC) |
VCC | Power Input |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | (124 other parts) |
Tags | generic ic qfp smd |
:heavy_check_mark: Package checks passed
:heavy_check_mark: Clearance checks passed
Very sorry for the late review:
That's about all I can see, this is good.
Bot!
This review is brought to you by the Horizon EDA Poolbot commit 33131f8.
State | Type | Name | Checks | Version | Filename |
---|---|---|---|---|---|
New | Entity | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | entities/ic/mcu/microchip/ATmega328P-AU.json |
New | Package | QFP32 | :heavy_check_mark: Pass | 0 :heavy_check_mark: | packages/ic/smd/qfp/QFP32/package.json |
New | Part | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | parts/ic/mcu/microchip/ATmega328P-AU.json |
New | Symbol | ATmega328P-AU | :heavy_check_mark: Pass | 0 :heavy_check_mark: | symbols/ic/mcu/microchip/ATmega328P-AU.json |
New | Unit | ATmega328P-AU | :heavy_check_mark: Pass | 1 :x: (>0) | units/ic/mcu/microchip/ATmega328P-AU.json |
Bold items are from this PR
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
MPN | ATmega328P-AU |
Value | |
Manufacturer | Microchip (15 other parts) |
Datasheet | http://ww1.microchip.com/downloads/en/DeviceDoc/ATmega48A-PA-88A-PA-168A-PA-328-P-DS-DS40002061A.pdf |
Description | AVR 32KiB Flash 2KiB SRAM 2.5V/3.3V/5V 32-Pin TQFP |
Tags | avr mcu |
Pad | Gate | Pin |
---|---|---|
1 | Main | PD3 |
2 | Main | PD4 |
3 | Main | GND |
4 | Main | VCC |
5 | Main | GND |
6 | Main | VCC |
7 | Main | PB6 |
8 | Main | PB7 |
9 | Main | PD5 |
10 | Main | PD6 |
11 | Main | PD7 |
12 | Main | PB0 |
13 | Main | PB1 |
14 | Main | PB2 |
15 | Main | PB3 |
16 | Main | PB4 |
17 | Main | PB5 |
18 | Main | AVCC |
19 | Main | ADC6 |
20 | Main | AREF |
21 | Main | GND |
22 | Main | ADC7 |
23 | Main | PC0 |
24 | Main | PC1 |
25 | Main | PC2 |
26 | Main | PC3 |
27 | Main | PC4 |
28 | Main | PC5 |
29 | Main | PC6 |
30 | Main | PD0 |
31 | Main | PD1 |
32 | Main | PD2 |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | Microchip (15 other parts) |
Prefix | U |
Tags | avr mcu |
Gate | Suffix | Swap group | Unit |
---|---|---|---|
Main | 0 | ATmega328P-AU |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | Microchip (15 other parts) |
Pin | Direction | Alternate names |
---|---|---|
ADC6 | Input | |
ADC7 | Input | |
AREF | Input | |
AVCC | Power Input | |
GND | Power Input | |
PB0 | Bidirectional | ICP1 (NC), PCINT0 (NC), CLKO (NC) |
PB1 | Bidirectional | PCINT1 (BiDi), OC1A (BiDi) |
PB2 | Bidirectional | PCINT2 (BiDi), OC1B (BiDi) |
PB3 | Bidirectional | MOSI (BiDi), PCINT3 (BiDi), OC2A (BiDi) |
PB4 | Bidirectional | PCINT4 (BiDi), MISO (BiDi) |
PB5 | Bidirectional | SCK (BiDi), PCINT5 (BiDi) |
PB6 | Bidirectional | TOSC1 (PIn), PCINT6 (PIn), XTAL1 (PIn) |
PB7 | Bidirectional | TOSC2 (BiDi), PCINT7 (BiDi), XTAL2 (BiDi) |
PC0 | Bidirectional | ADC0 (BiDi), PCINT8 (BiDi) |
PC1 | Bidirectional | ADC1 (BiDi), PCINT9 (BiDi) |
PC2 | Bidirectional | ADC2 (BiDi), PCINT10 (BiDi) |
PC3 | Bidirectional | ADC3 (BiDi), PCINT11 (BiDi) |
PC4 | Bidirectional | PCINT12 (BiDi), ADC4 (BiDi), SDA (BiDi) |
PC5 | Bidirectional | PCINT13 (BiDi), ADC5 (BiDi), SCL (BiDi) |
PC6 | Bidirectional | RESET (BiDi), PCINT14 (BiDi) |
PD0 | Bidirectional | RXD (BiDi), PCINT16 (BiDi) |
PD1 | Bidirectional | TXD (BiDi), PCINT17 (BiDi) |
PD2 | Bidirectional | INT0 (BiDi), PCINT18 (BiDi) |
PD3 | Bidirectional | INT1 (BiDi), PCINT19 (BiDi), OC2B (BiDi) |
PD4 | Bidirectional | T0 (BiDi), PCINT20 (BiDi), XCK (BiDi) |
PD5 | Bidirectional | T1 (PIn), PCINT21 (PIn), OC0B (PIn) |
PD6 | Bidirectional | AIN0 (BiDi), PCINT22 (BiDi), OC0A (BiDi) |
PD7 | Bidirectional | PCINT23 (OC), AIN1 (OC) |
VCC | Power Input |
:heavy_check_mark: Checks passed
Attribute | Value |
---|---|
Manufacturer | (124 other parts) |
Tags | generic ic qfp smd |
:heavy_check_mark: Package checks passed
:heavy_check_mark: Clearance checks passed
I would like to continue with @endofexclusive's pull request #138 . @carrotIndustries wrote:
I will set the PR to Draft until I'm done with that.