horizon-eda / horizon

Horizon is a free EDA package
https://horizon-eda.org/
GNU General Public License v3.0
1.12k stars 83 forks source link

Kicad package import fails on RPi_Pico_SMD_TH #654

Open jsgf opened 2 years ago

jsgf commented 2 years ago

The import fails with a bunch of unsupported pad stacks, but also a Critical error "SEXPR is not a double type". From a process of elimination, this appears to be from lines with (drill (offset ...)):

  (pad 1 smd rect (at -8.89 -24.13) (size 3.5 1.7) (drill (offset -0.9 0)) (layers F.Cu F.Mask))

Full set of errors:

Seq | Level   | Domain                  | Message; Detail
0   | Warning | Import                  | Pad '3' is unsupported; type=thru_hole shape=rect
1   | Warning | Import                  | Pad '8' is unsupported; type=thru_hole shape=rect
2   | Warning | Import                  | Pad '13' is unsupported; type=thru_hole shape=rect
3   | Warning | Import                  | Pad '18' is unsupported; type=thru_hole shape=rect
4   | Warning | Import                  | Pad '23' is unsupported; type=thru_hole shape=rect
5   | Warning | Import                  | Pad '28' is unsupported; type=thru_hole shape=rect
6   | Warning | Import                  | Pad '33' is unsupported; type=thru_hole shape=rect
7   | Warning | Import                  | Pad '38' is unsupported; type=thru_hole shape=rect
0   | Critical| Import                  | exception: SEXPR is not a double type!; 

File in question:

RPi_Pico_SMD_TH.kicad_mod.txt

carrotIndustries commented 2 years ago

This is because offset drills aren't supported yet and the importer assumes that the drill is specified as a single double rather than another expression.

jsgf commented 2 years ago

Yeah that's what I thought. Should I leave this open as a TODO/feature request?

carrotIndustries commented 2 years ago

Should I leave this open as a TODO/feature request?

Yes, even though supporting it would require the kicad package importer to create its own padstacks.