Separate multi labeled pins for better readability

horizon-eda / horizon

Horizon is a free EDA package

https://horizon-eda.org/

GNU General Public License v3.0

1.11k stars 82 forks source link

Separate multi labeled pins for better readability #687

Closed oxplot closed 2 years ago

oxplot commented 2 years ago

Initial discussion on discourse.

Currently, when showing multiple alternate pin names, they are separated by a single space on the schematics:

This is somewhat difficult to read at times and may be mistaken in some scenarios as a single label. This PR adds unicode MIDDLE DOT as a visual separator between the labels:

Screenshot from 2022-09-02 17-34-56

carrotIndustries commented 2 years ago

That's is indeed more readable than just a single space. There are some other code paths, most notably for the "all" pin display mode, that also need to be changed to match the new style in SchematicSymbol::apply_pin_names.

carrotIndustries commented 2 years ago

LGTM apart from the failing style check.

carrotIndustries commented 2 years ago

Sorry, just one more thing: How about factoring the separator out into a string constant?