search

horizon-eda / horizon

Horizon is a free EDA package
https://horizon-eda.org/
GNU General Public License v3.0
1.08k stars 79 forks source link

Fix crash when pns is walking around arcs #741

Closed moritz-meier closed 9 months ago

moritz-meier commented 9 months ago

When routing a track in walkaround mode, horizon crashes when the routed track collides with an arc. This due to the assert statement:

horizon-imp: ../3rd_party/router/kimath/src/geometry/shape_collisions.cpp:504: bool Collide(const SHAPE_ARC&, const SHAPE_CIRCLE&, int, int*, VECTOR2I*, VECTOR2I*): Assertion (!aMTV) failed.

In KiCad this assert statement was removed to fix this problem, so i think it should be ok to do the same here.

https://gitlab.com/kicad/code/kicad/-/commit/df9cf0a0c39ed99527b0c04e3892e8dd7ed603e7

Would be nicer to port the entire KiCad Router 7.0.7 or at least 6.0.11 to horizon, but i tried and then decided it is to much trouble for just a small fix.

carrotIndustries commented 9 months ago

Would be nice to have this as two separate commits: