horizontalsystems / unstoppable-wallet-android

A powerful non-custodial multi-wallet for Bitcoin, Ethereum, Binance Smart Chain, Avalanche, Solana and other blockchains. Non-custodial crypto and NFT storage, onchain decentralized exchange, institutional grade analytics for cryptcurrency and NFT markets, extensive privacy controls and human oriented design. Implemented on Kotlin.
https://unstoppable.money
MIT License
889 stars 364 forks source link

v0.33.0 and v0.33.1 do not allow setting maxFee below current baseFee #6234

Closed aleqx closed 1 year ago

aleqx commented 1 year ago

This may be related to the other issue I posted (which was closed but not confirmed fixed): https://github.com/horizontalsystems/unstoppable-wallet-android/issues/6105

Just did a fresh install of 0.33.0 from F-droid on Android 13 (added on 2023-06-18). Tried to use a max fee that is lower than current block base fee, the app gives the error below and doesn't allow me to continue. This is the first transaction attempt since reinstalling. I thought this was already fixed.

fee cap less than block base fee: address 0x..., gasFeeCap: 12000000000 baseFee:18268580977

Image from Gyazo

aleqx commented 1 year ago

I can confirm that the 0.33.0 APK from Github does NOT have this problem (the same as with https://github.com/horizontalsystems/unstoppable-wallet-android/issues/6105)

... so the F-droid versions are definitely compiled from different sources ... this is concerning

abdrasulov commented 1 year ago

@aleqx thanks for reporting. We have rebuilt v0.33 a few times. Most likely the F-droid has not updated it yet. Let's check it after a while.

aleqx commented 1 year ago

I can confirm that 0.33.1 from Github now does the same thing and shows other bugs too. 0.33.0 as well.

If I add a new RPC for Ethereum, e.g. https://rpc.mevblocker.io (a valid RPC) then I can connect the wallet via Wallet Connect to Aave and get to confirm a transaction, but if I try to lower the fee it gives me the above error and doesn't allow me to continue (it should be a warning, not error).

If I switch back to the hardcoded Infura (ws) RPC and redo all the operations above then it allows me to lower the fee without an error (just a warning)

Also, i have 3 connections in the Wallet Connect screen, and I cannot delete them. Swiping left and tapping the (-) button doesn't do anything. Clicking on the connection it says "Offline" and "No internet" at the bottom. False, I have internet on the phone working just fine. This is irrespective of which RPC I'm using. These connections were made using the default Infura (ws) RPC.

Also, even after reinstalling UW and not adding any new RPC, I can no longer tconnect to Arbitrum on Aave. The connection dialog pops up but I cannot choose the network any more to change it to Arbitrum (previously there was a dropdown list). It just sticks to Ethereum mainnet instead of Arbitrum. If I try a transaction on Arbitrum the website detects that my wallet is on Ethereum mainnet and asks to switch, but it cannot switch (and no popup comes on in UW to switch either).

There seems to be multiple bugs here.

App Info:
         - Current Time: Jul 9, 2023, 00:27
         - App Version: 0.33.1
         - Device Model: samsung SM-Gxxxx
         - OS Version: Android 13 (33)

App Log:

Version History:
         - 0.33.0: Jun 22, 2023, 17:05
         - 0.33.1: Jul 9, 2023, 00:06

Wallets Status:
         - XYZ:
                 - Origin: Restored
                 - Mnemonic: 24

Blockchain Status:
         - Bitcoin-bip84:
                 - Synced Until: Jul 9, 2023, 00:20
                 - Syncing Peer: N/A
                 - Derivation: bip84
                 - Sync State: Synced
                 - Last Block Height: 797856
                 - Peer 1:
                         - Status: Synced
                         - Host: 5.144.88.83
                         - Best Block: 797856
                         - User Agent: /Satoshi:0.13.0/
                         - tasks: no tasks
                 - Peer 2:
                         - Status: Synced
                         - Host: 138.201.20.142
                         - Best Block: 797856
                         - User Agent: /Satoshi:24.0.1(pro-bitcoin.io)/
                         - tasks: no tasks
                 - Peer 3:
                         - Status: Synced
                         - Host: 185.25.48.184
                         - Best Block: 797856
                         - User Agent: /Satoshi:22.0.0/
                         - tasks: no tasks
                 - Peer 4:
                         - Status: Synced
                         - Host: 79.115.184.219
                         - Best Block: 797856
                         - User Agent: /Satoshi:24.0.1/
                         - tasks: no tasks
                 - Peer 5:
                         - Status: Synced
                         - Host: 70.80.124.37
                         - Best Block: 797856
                         - User Agent: /Satoshi:25.0.0/
                         - tasks: no tasks
                 - Peer 6:
                         - Status: Synced
                         - Host: 50.24.188.75
                         - Best Block: 797856
                         - User Agent: /Satoshi:24.0.1/
                         - tasks: no tasks
                 - Peer 7:
                         - Status: Synced
                         - Host: 34.84.22.94
                         - Best Block: 797856
                         - User Agent: /Satoshi:0.20.1/
                         - tasks: no tasks
                 - Peer 8:
                         - Status: Synced
                         - Host: 192.241.135.179
                         - Best Block: 797856
                         - User Agent: /Satoshi:25.0.0/
                         - tasks: no tasks
                 - Peer 9:
                         - Status: Synced
                         - Host: 75.83.203.225
                         - Best Block: 797856
                         - User Agent: /Satoshi:25.0.0/
                         - tasks: no tasks
                 - Peer 10:
                         - Status: Synced
                         - Host: 68.206.159.58
                         - Best Block: 797856
                         - User Agent: /Satoshi:0.18.0/
                         - tasks: no tasks

Market Last Sync Timestamps:
         - Coins: 1688474855
         - Blockchains: 1688718216
         - Tokens: 1688474855