search

horizontalsystems / unstoppable-wallet-android

A powerful non-custodial multi-wallet for Bitcoin, Ethereum, Binance Smart Chain, Avalanche, Solana and other blockchains. Non-custodial crypto and NFT storage, onchain decentralized exchange, institutional grade analytics for cryptcurrency and NFT markets, extensive privacy controls and human oriented design. Implemented on Kotlin.
https://unstoppable.money
MIT License
825 stars 356 forks source link

Update WalletConnect SDK #6911

Open Dianaaiym opened 6 months ago

Dianaaiym commented 6 months ago

https://docs.walletconnect.com/web3modal/about

nuke-web3 commented 4 months ago

I am trying to connect via a QR here https://tokenproof.xyz/enrollment

While I do get the scanner to recognize the scan, nothing further happens. I am dropped into the page with "you don't have any connected dapps" . I have tried on a different app https://github.com/keepkey/keepkey-desktop/issues/667#issuecomment-1942163365 with no success. I am able to get to a signing phase on this other app though, where as I get nothing at all with unstoppable.

Will this be resolved one an update to the SDK is made?

abdrasulov commented 4 months ago

I am trying to connect via a QR here https://tokenproof.xyz/enrollment

While I do get the scanner to recognize the scan, nothing further happens. I am dropped into the page with "you don't have any connected dapps" . I have tried on a different app keepkey/keepkey-desktop#667 (comment) with no success. I am able to get to a signing phase on this other app though, where as I get nothing at all with unstoppable.

Will this be resolved one an update to the SDK is made?

Hello @NukeManDan. We could not reproduce the issue. We successfully get connected with wallet connect to the https://tokenproof.xyz/enrollment. After scanning the QR code the unstoppable app shows the "Connect to DApp" dialog with Connect and Cancel buttons. Please try once again and let us know if the issue persists

nuke-web3 commented 4 months ago

Indeed, it worked when trying on a different desktop just now :tada: Unclear how I could access logs to see what the error could be via the app. :shrug:

Sorry for the noise on the OP issue, I do look forward to an update including the newer WC SDK. :grin:

nuke-web3 commented 2 months ago

Trying to connect to https://devfolio.co https://siwe.devfolio.co/?nonce=....&domain=api.devfolio.co...

I get in the browser console WalletConnect cannot connect. Error: Chains must not be empty and on the app I must navigate away them back tot he WC page to see an Unnamed --- pairing, but have no response in browser or on the app to try and connect at all. Again not sure if this is related to the SDK but would love better support for WC overall in this otherwise great wallet app! :pray:

rafaelekol commented 2 months ago

@NukeManDan currently we have issues with updating WalletConnect SDK, which we haven't resolved yet. I also tried to connect to https://devfolio.co/ with Trust wallet and with demo app from WalletConnect, but both of them didn't connect to devfolio. I guess there is some issues on devfolio side.

abdrasulov commented 1 month ago

We could not update to the latest v Bom 1.31.4.

See https://github.com/WalletConnect/WalletConnectKotlinV2/issues/1409