horizontalsystems / unstoppable-wallet-android

A powerful non-custodial multi-wallet for Bitcoin, Ethereum, Binance Smart Chain, Avalanche, Solana and other blockchains. Non-custodial crypto and NFT storage, onchain decentralized exchange, institutional grade analytics for cryptcurrency and NFT markets, extensive privacy controls and human oriented design. Implemented on Kotlin.
https://unstoppable.money
MIT License
903 stars 370 forks source link

Function that fetch coins data from coingecko #7041

Open notpri opened 9 months ago

notpri commented 9 months ago

Plase add functions that fetch info(price, icon etc) about coins/tokens we add through contract addresses. This will save you a big time as you will the only focus on bug fixes and new features.

serrq commented 9 months ago

Absolutely I agree. Too much added tokens without price, info graph, ticker icon, etc.

We need of an easier way to add a new token (and backup it in UW backup system as well) without too much hassles or bad shown (see the image below).

1000105969

serrq commented 9 months ago

Title change proposal:

“We need of an easier way to add tokens (like ERC-20)”

What do you think?

notpri commented 9 months ago

Title change proposal:

“We need of an easier way to add tokens (like ERC-20)”

What do you think?

contract adress is the easiest way to add tokens. i am suggesting fetching tokens data as well

serrq commented 9 months ago

I mean an easier way to get all the package (price, stats, ticker icon, contract address, etc.) with just adding a Coingecko URL in the app.

notpri commented 9 months ago

I mean an easier way to get all the package (price, stats, ticker icon, contract address, etc.) with just adding a Coingecko URL in the app.

good thinking. but you can easily get contract address from coingecko

notpri commented 9 months ago

I mean an easier way to get all the package (price, stats, ticker icon, contract address, etc.) with just adding a Coingecko URL in the app.

however it will be very helpful for adding networks/blockchains.

serrq commented 9 months ago

Also the Coingecko API ID field is an useful method to automatically (and easily) import a token/network in UW.

1000106073

notpri commented 8 months ago

@serrq I just got a very interesting point in my mind. Adding coins/tokens through coingecko URL is a bad idea as this URL can be used to exploit UW. URLs can be dangerous and that will make UW more vulnerable and will not give much benefit because you either copy the URL ( which can be malicious) or copy contract address (safer) and the work will be done. Also when they add function of fetching coins data, then any data like name, price etc of that specific contract address will be fetched from coingecko. So, I am not confident with URL suggestions.

notpri commented 8 months ago

if you dont know what exploits I'm talking about then have a research on URLs and how they can be used to exploit.