horizontalsystems / unstoppable-wallet-android

A powerful non-custodial multi-wallet for Bitcoin, Ethereum, Binance Smart Chain, Avalanche, Solana and other blockchains. Non-custodial crypto and NFT storage, onchain decentralized exchange, institutional grade analytics for cryptcurrency and NFT markets, extensive privacy controls and human oriented design. Implemented on Kotlin.
https://unstoppable.money
MIT License
879 stars 363 forks source link

Support hardware wallets (with being able to send transactions, not only to watch addresses) #7481

Open d4f5409d opened 4 months ago

d4f5409d commented 4 months ago

Trezor, Ledger, etc.

serrq commented 4 months ago

I like this one (open source).

https://keyst.one/shop/products/keystone-3-pro

zz64 commented 3 months ago

@serrq , Unstoppable wallet + Keystone is my dream. Do you have to offer the device to the developer to add support?

all is need here: https://github.com/KeystoneHQ

serrq commented 3 months ago

@zz64 are you in the Keystone dev team?

zz64 commented 3 months ago

No. I'm just a consumer

d4f5409d commented 3 months ago

@serrq , Unstoppable wallet + Keystone is my dream. Do you have to offer the device to the developer to add support?

all is need here: https://github.com/KeystoneHQ

My dream is UW + Trezor 😉

zz64 commented 3 months ago

@serrq , Trezor not fully offline like Keystone. need online apps apps for adding Token's... like Ledger.

serrq commented 3 months ago

I am not necessarily against "internet" capability. Just some good behaviors.

Like only wifi connection in the hardware wallet, an embedded (VPN) wireguard client, an optional tor client, and double ratchets e2e encryption built-in to protect data (at rest and in transit).

A wifi hardware button on the chassis it is enough to on/off internet at the user's need.

d4f5409d commented 3 months ago

Internet doesn't mean anything until keys and transactions stay and happen on the hardware wallet.

serrq commented 3 months ago

Internet doesn't mean anything until keys and transactions stay and happen on the hardware wallet.

It requires a (jail) dedicated chip that hardware wallet own.

zz64 commented 3 months ago

@d4f5409d , using Trezor, can add Token/App without internet ? can upgrade firmware with cmd utilities (like serial console) ? Why no firmware binary in Trezor github releases ? I really like this device, it will be my next choice after the Keystone.

esengulov commented 3 months ago

@zz64 @serrq thanks for the input guys. This has been on our radar for some time but we haven't got there yet. We are likely to add it in the future and it will probably be a premium feature that can be unlocked via in app purchase.

serrq commented 3 months ago

Also this one is on my radar (open source):

• https://www.onekey.so/products/onekey-pro-hardware-wallet/