horizontalsystems / unstoppable-wallet-android

A powerful non-custodial multi-wallet for Bitcoin, Ethereum, Binance Smart Chain, Avalanche, Solana and other blockchains. Non-custodial crypto and NFT storage, onchain decentralized exchange, institutional grade analytics for cryptcurrency and NFT markets, extensive privacy controls and human oriented design. Implemented on Kotlin.
https://unstoppable.money
MIT License
883 stars 364 forks source link

In app Browser #7600

Open morpheusia opened 3 months ago

morpheusia commented 3 months ago

Hello, there are a lot of problems with walletconnect, each release Its a roll of die that decides wether WC works properly, and it becoming a problem.

Is it possible to integrate an In-app browser for dapps like trustwallet or other wallets?

Thanks

serrq commented 3 months ago

I am strongly opposed to this solution because in the field of security it would widen the attack surface of the app, because a browser must be continually updated with security patches and because we must not run after fashions. If others are wrong, we don’t have to do it ourselves. Simplification doesn’t always mean doing things well.

This kind of solution also add other lines of code to have to maintain.

In addition, the user experience of an integrated browser is really poor, with loading bars and browser-like options that badly apply to a modern, fast and aesthetically pleasing app.

So what do we do?

It repairs, improves, updates Wallet Connect.

serrq commented 3 months ago

It is not excluded that in the future new connection protocols will arrive, which will go alongside Wallet Connect.

I myself, in a previous issue, implicitly requested Ton Connect, and who knows that the team does not implement it. We’ll see.

morpheusia commented 3 months ago

@serrq you have a point, but then wallet connect must be given more attention than it currently has, because literally every release it might not work

serrq commented 2 months ago

Another consideration. More DEXs arrive within UW, less you will use WC.