search

horoeka-2022 / gardenz

Empowering community gardens in New Zealand
0 stars 1 forks source link

Consistent Promise Handling - async / await: Batch 4 #76

Open clementine-smart opened 1 year ago

clementine-smart commented 1 year ago

There are over 150 uses of .then() in the codebase at the time of this issue creation. The objective is to eventually get them all converted to a single consistent style with async...await, instead, but it would be impractical to do them all at once.

Note that there is one exception where async / await can be problematic - inside useEffect() hook calls. Read this blog post to find out how to handle it correctly.

Considering the above exception, find uses of .then() in the following files and replace them with async / await-style promise handling.

image

ciara-doelman commented 1 year ago

There is a broken test that comes up when you run "npx jest EditEvent.test.js" that is in tests/e2e/adminEditEvent.test.js:34:1, we have left this test as is for now as it is not mentioned in this ticket.