horosproject / horos

Horos™ is a free, open source medical image viewer. The goal of the Horos Project is to develop a fully functional, 64-bit medical image viewer for OS X. Horos is based upon OsiriX and other open source medical imaging libraries. Horos is made freely available under the GNU Lesser General Public License, Version 3 (LGPL-3.0). Horos is linked against the Grok JPEG 2000 library, for fast viewing of JPEG 2000 images. This library is licensed under the terms of the GNU Affero General Public License.
http://www.horosproject.org
Other
487 stars 143 forks source link

Spinning Wheel of Death #32

Closed ky-tech-guy closed 8 years ago

ky-tech-guy commented 9 years ago

When I use Horos, I have on average 1-3 episodes of the spinning wheel of death, where horos stops responding and I have to force close the application. This problem seems to happen sporadically and doesn't follow a predictable pattern. The crash generates a report log that I can send to apple. However, I am unaware if the Horos team is actually receiving these logs or not. This issue is a large obstacle in preventing Horos from becoming a full-time production level software program. How can I help address this issue?

All the best,

Radiology Resident

fvpolpeta commented 9 years ago

Thanks for this report. We have been working in strategy to receiving Horos logs. Meanwhile, I would like you to request you to copy&paste the (crash/freeze) log in a file and attach it here.

Let me know if you need help.

Regards

ky-tech-guy commented 8 years ago

horos.txt crash log

ky-tech-guy commented 8 years ago

horos-crash-report2.txt crash log 2

fvpolpeta commented 8 years ago

Thanks. We are going to release version 1.1.4 of Horos, which adds a Crash Reporter. The issue you reported is already under investigation. Regards

PabloSau commented 8 years ago

In Horos 1.1.4, the Crash Reporter prompts that the Report is sent to Apple. Is that correct or it means to be sent to Horos?

ky-tech-guy commented 8 years ago

The crash reporter feature does not appear to work in Horos 1.1.4. I have had Horos crash on me several times and when I re-open it, no crash log is created. It actually worked the very first time horse crashed but then after that it has not worked.

fvpolpeta commented 8 years ago

Dear Sir;

Thanks for using Horos and for reporting bugs.

Please, check if the following nightly build improves your user experience by solving/minimizing the freezing episodes you did report.

https://dl.dropboxusercontent.com/u/15111870/PurView/HorosNightly.app.zip

Look forward to hearing from you.

ky-tech-guy commented 8 years ago

So when I use the nightly build, I still get the spinning wheel of death at about the same frequency. Maybe a little less. After I force quit Horos a crash report is created but it sends the report to apple and not to Horos. I believe that is not what the crash reporting module is intended to do.

All the best,

Will

fvpolpeta commented 8 years ago

Hi Will;

Thanks for the feedback.

1) The Horos crash reporting module is not being opened because Horos actually didn't crash when you forced to quit. There is no crash info in the logs that will make it open. By killing Horos with "kill -11 " which emulates a SIGSEGV will make it open for example.

2) I'm not being able these freezing you are reporting. Can you provide me with anonymized series for testing purposes. Also, give me details about your usability workflow until you get the spinning wheel of death.

Thks in advance

aazidizel commented 8 years ago

random crash of horos version 1.1.5 with loading images stuck at 0% and hang on closing the image viewer window. crash report is attached.

Horos 1.1.5 crash report.txt

fvpolpeta commented 8 years ago

Hi. Thanks for your report.

We have been working to address an issue related to incompatibility between OSX versions. Horos supports 10.8.x to 10.11.x.

A new version is being prepared, and we believe it will solve your problem.

Please, I ask you to download a GM build from the link below and inform how it goes.

https://dl.dropboxusercontent.com/u/15111870/PurView/Horos.dmg

Thanks for your help in advance.

Best

ky-tech-guy commented 8 years ago

If you use the terminal command sudo kill -11 PID# ( you can look up the PID# in activity monitor) to close the program whenever it stops responding it will generate a crash log for horos to send.

aazidizel commented 8 years ago

Horos 1.1.6 also has the same random crashes with loading images stuck at 0% and hang on closing the image viewer window. screen shot 2016-01-15 at 10 43 00 am Horos 1.1.6 crash report.txt

fvpolpeta commented 8 years ago

Please, send the anonymized dataset of the picture.

Thanks

aazidizel commented 8 years ago

here the anonymized files you requested. Anonymized.zip

fvpolpeta commented 8 years ago

Hi Aazidizel;

Thanks for the images. I can actually open them with no issues. I noticed in you screenshot that you probably triggered a function (3D, 3MPR, etc) before the series is completely loaded. That makes Horos show that "loading" pop up. Which function was that.

Please, try to detail your steps until you you face that problem.

Thanx

aazidizel commented 8 years ago

Thanks for the reply. yes i used the 3D function. but as i mentioned before, the hang happens randomly and with no particular image set. it happens even without triggering the 3D function. I generally come to know that horos is going to hang when it shows 0% in the viewer title bar. I have marked it in the screen shot with a red circle. screen-shot-2016-01-15-at-10 43 00-

fvpolpeta commented 8 years ago

Please try this nightly build and inform us how it performs:

https://dl.dropboxusercontent.com/u/15111870/PurView/HorosNightly.app.zip

BR

Staslas commented 8 years ago

glad im not the only one with the same bug. every 1/4 CT scans open like that.

baccheschi commented 8 years ago

I've had this problem since forever. Actually since I have started using Horos, but it has become more and more frequent. Now it happens every two exams opened, and not just with large CT sets of images, but also with short MRI sets. It happens exactly as aazidizel stated. I know it's gonna happen when the 0% shows up. I thought it was because of my slow hardware and changed my mac recently, mainly for running better virtual machines and my primary DICOM viewer, PACS e RIS softwares, that run on windows. I now have the fastest running MacBook Pro (Retina, 15-inch, Mid 2015, with 2,8 GHz Core i7, 16 GB RAM and 2GB VRAM AMD Radeon R9 M370X) and the problem got even worse. And It's even worse when I'm using my 4K monitor. Bottom Line: Happens really often with any kind of image sets. I forgot to mention that it seems to happen less frequently when I have less windows tiled. I usually use 4 windows per screen, but I've recently been trying to use just 2 to see how it goes.

fvpolpeta commented 8 years ago

We have this nightly build:

https://dl.dropboxusercontent.com/u/15111870/PurView/Horos.app.Nightly%2020160422_161824.zip

Try it and let us know if the problem remains

BR

ky-tech-guy commented 8 years ago

I tried downloading the nightly build and it said the file is corrupted and wouldn't let me open it.

fvpolpeta commented 8 years ago

I just clicked the link above, downloaded it, unzipped and run it.

Please try again.

(Only runs in El Capitan)

fvpolpeta commented 8 years ago

https://dl.dropboxusercontent.com/u/15111870/PurView/Horos.app.Nightly%2020160424_205640.zip

ky-tech-guy commented 8 years ago

I was able to get it do open after updating to the latest version of El Capitan. I have been using the highly build and it seems to work very well. So far I haven't had a single spinning wheel of death. I will keep testing it and will report any problems if I notice them.

fvpolpeta commented 8 years ago

Great. The last link above is a new build, which fix a exception during initialization.

baccheschi commented 8 years ago

have been using the nightly build since you posted the latest version. No spinning wheel of death either, but, besides the excepciona during initialization, there is a shortage of options in the preferences menu. And a problem with downloading exams from some servers. screenshot 2016-04-25 08 56 38

screenshot 2016-04-25 08 58 27

And this is the version:

screenshot 2016-04-25 08 56 50
baccheschi commented 8 years ago

So I'm still using 1.1.7 to retrieve sets of images, and then switch back to this nightly build to view and reformat.

fvpolpeta commented 8 years ago

Hi baccheschi;

Thank you so much for your feedback. We are working to port Horos to El Capitan. Some interface glitches like this you reported will be fixed asap.

In respect to the WADO problem, we will be checking how to fix asap too. Is this what you said are causing the download of images? Your DICOM query/retrieve is also failing?

Please, let us know issues you find.

BR

baccheschi commented 8 years ago

No, the DICOM query is working, And I have just tested retrieving from a non-WADO port server and the transfer worked just fine. Actually, one out of two transfers worked. The other one remains listed on the Activity drawer with the transfer status bar fully loaded but nothing happens. It is also a frequent glitch on 1.1.7

Staslas commented 8 years ago

Tried the first nightly build and i was unable to run plugins so i switch back to 1.1.7. But then i realised that this problem hasn't occurred pretty a while. Also using latest El Capitan.

fvpolpeta commented 8 years ago

Hi Staslas

Plugins are disable in Nightly Build. We are having to rebuild the plugins database for enabling them in Horos.

Please, let us know which plugins you are using.

BR

Staslas commented 8 years ago

Using dental3dplugin, pdf to dicom. Also noticed problem with blank slices disappeared. I hope so.

fvpolpeta commented 8 years ago

Hey guys, how Horos is performing in respect to spinning wheel of death? Better? Same? Rare?

baccheschi commented 8 years ago

Still no spinning weel with this version so far! Just the settings problem I mentioned before, the retrieving issue and when I use 3D MPR I can't change views. I usually use the screen divided in 3 columns, but the system only allows the use of 2 columns with two lines on the left column.

fvpolpeta commented 8 years ago

Great to here you have no freezing. We are working to fix these GUI problems and provide builds of the plugins the community are using.

BR

ky-tech-guy commented 8 years ago

No issues with the spinning wheel of death so far. Much improved from the prior version.

fvpolpeta commented 8 years ago

Thanks.

https://dl.dropboxusercontent.com/u/15111870/PurView/Horos.app.Nightly%2020160426_205020.zip

This fixes 3D MPR view formatters. The preferences panel will consume more time to be fixed.

BR

ky-tech-guy commented 8 years ago

There is a gap between the albums drawer and the database panel. Do you have any nightly builds that fix this problem? Thanks.

Will

fvpolpeta commented 8 years ago

Will;

Please, customize the Toolbar by adding the "Reset Views" button. Then press it and let me know if the problem was fixed.

You can do that manually too (dragging the border to left).

BR

ky-tech-guy commented 8 years ago

I was able to manually drag the database panel to the left. However, there is still an awkward gap between the albums panels and the tool bar above. I attached an image for details.

screen shot 2016-04-29 at 8 26 26 pm
fvpolpeta commented 8 years ago

Got it. We will fix that asap.

Tks

fvpolpeta commented 8 years ago

Here it is:

https://dl.dropboxusercontent.com/u/15111870/PurView/Horos.app.Nightly%2020160429_233040.zip

JPEG2DICOM (in case you need it)

https://dl.dropboxusercontent.com/u/15111870/PurView/JPEGtoDICOM.horosplugin.zip

fvpolpeta commented 8 years ago

Please, try this build and let me know your findings. The release of version 2.0.0 of Horos will happen soon and your feedback is welcome.

https://dl.dropboxusercontent.com/u/15111870/PurView/HorosNightly.dmg

If everything goes fine, please close the issue.

Best Regards

Fauze

ky-tech-guy commented 8 years ago

I have used the newest build of Horos and it seems to work well. I have yet to experience episodes of crashing. Thanks for your hard work.

All the best, Will

ky-tech-guy commented 8 years ago

I spoke too soon. I have been using the nightly build above and I am starting to have issues again with the spinning wheel of death. I will report more details as I experience errors.

fvpolpeta commented 8 years ago

The main difference - among other minor isolated things - is that the build above has plugins enabled. So I kindly request you to go to the Plugin Manager and disable your plugins to check which one may be causing problems.

Thanks in advance

fvpolpeta commented 8 years ago

Hey Ky-Tech-Guy;

Use this build in contrast to the one I offered you yesterday.

https://dl.dropboxusercontent.com/u/15111870/PurView/Horos%202016-05-25%2009-03-11.zip

In this build I removed a decoding locker that was added for some third-party image codecs that are not in the build.

Don't forget to check plugins.

Tks

ky-tech-guy commented 8 years ago

I had the following 4 plugins installed on my machine -> PDF to DICOM, volume calculator, JPEG to DICOM, and reporter. After uninstalling them Horos function is back to normal.

fvpolpeta commented 8 years ago

Got it. The plugins database is being rebuilt. Gradually validated plugins will be added to the Horos plugin manager repository. JPEG to DICOM is the only validated on available.

The build from this morning might increase your J2K decoding speed of multiple images.

Best