search

horosproject / horos

Horos™ is a free, open source medical image viewer. The goal of the Horos Project is to develop a fully functional, 64-bit medical image viewer for OS X. Horos is based upon OsiriX and other open source medical imaging libraries. Horos is made freely available under the GNU Lesser General Public License, Version 3 (LGPL-3.0). Horos is linked against the Grok JPEG 2000 library, for fast viewing of JPEG 2000 images. This library is licensed under the terms of the GNU Affero General Public License.
http://www.horosproject.org
Other
477 stars 143 forks source link

3d curved MPR crashes #519

Open tommyclaus opened 4 years ago

tommyclaus commented 4 years ago

On my MacBook Pro (15-inch, 2017), macos catalina 10.15.1, it is impossible to use 3d curved MPR with horos 4.0.0 since it crashes (spinning disk pointer appears)

fvpolpeta commented 4 years ago

Thanks. The issue if confirmed and will be investigated.

Fauze

On 12 Dec 2019, at 05:38, tommyclaus notifications@github.com wrote:

On my MacBook Pro (15-inch, 2017), macos catalina 10.15.1, it is impossible to use 3d curved MPR crashes with horos 4.0.0 since it crashes (spinning disk pointer appears)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/horosproject/horos/issues/519?email_source=notifications&email_token=AB4C23J6ZSNEGW2RVGFJYETQYH2ALA5CNFSM4JZ23MFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H77MT4A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4C23JHCFQECOOLW4WJXFLQYH2ALANCNFSM4JZ23MFA.

horosproject commented 4 years ago

Hi -

Can you check if 3D curved MPR is performing fine with the following build:

https://horosproject.org/horos-content/Horos3.3.6.dmg

Thanks

Fauze

On 12 Dec 2019, at 08:52, Fauze Polpeta notifications@github.com wrote:

Thanks. The issue if confirmed and will be investigated.

Fauze

On 12 Dec 2019, at 05:38, tommyclaus notifications@github.com wrote:

On my MacBook Pro (15-inch, 2017), macos catalina 10.15.1, it is impossible to use 3d curved MPR crashes with horos 4.0.0 since it crashes (spinning disk pointer appears)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/horosproject/horos/issues/519?email_source=notifications&email_token=AB4C23J6ZSNEGW2RVGFJYETQYH2ALA5CNFSM4JZ23MFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H77MT4A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4C23JHCFQECOOLW4WJXFLQYH2ALANCNFSM4JZ23MFA.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/horosproject/horos/issues/519?email_source=notifications&email_token=ACQD7DSOG2SBMJSKT4SBKVLQYIQYLA5CNFSM4JZ23MFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGWNRUY#issuecomment-564975827, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQD7DTVCZPEHCCB5A4FWPDQYIQYLANCNFSM4JZ23MFA.

DD-P commented 4 years ago

For those following this bug, my testing found:

Compiling with Xcode 9.4.1 succeeds. Compiling with Xcode 10.0 and later fails. (Running on 10.14.6 and 10.15.2)

Swapping the built binaries from Horos/Contents/MacOS/Horos reverses behaviour (i.e. it's the main binary that's at fault, not any of the included frameworks).

Both builds are set to use libc++ not libstdc++, which was highlighted as no longer supported in the Xcode 10 release notes.

I believe the problem is in how VTK is being compiled, but this is built using CMake as a .a style statically linked binary in the main Horos binary. It seems hard to debug in Xcode given this, but looks to be throwing a series of NAN errors. I wonder if those with stronger C/C++ skills might be able to build and debug an isolated VTK in Xcode 10/11 to evaluate this further.

Many thanks, David

FrancoVargasB commented 2 years ago

I have the same issue on iMAC, does anybody know how to fix it?