horrible-little-slime / phccs

Apache License 2.0
6 stars 13 forks source link

hilarious campfire smoke messages needs to be sanitized #32

Closed Rinn closed 1 month ago

Rinn commented 1 month ago

an ampersand is all up in your business malforming a url

00:52:06 You acquire an item: campfire smoke
00:52:06 Your Campfire successfully looted!
00:52:06 Successfully created campfire smoke (1)
00:52:06 Preference choiceAdventure1394 changed from  to 1&message=of Nineteen City Churches_ (P. S. King & Son, Ltd.).
00:52:06 Using 1 campfire smoke...
00:52:06 Preference lastEncounter changed from angry tourist to Send up a Smoke Signal
00:52:06 Encounter: Send up a Smoke Signal
00:52:06 Invalid extra field: ' Son, Ltd.).'; no value supplied.
00:52:06 choice 1: (secret choice)
00:52:06   text = message
00:52:06 <a href="main.php" target="mainpane" class="error">Click here to continue in the relay browser.</a><br></br>
00:52:06 Stack trace:
00:52:06 
00:52:06 Preference choiceAdventure1394 changed from 1&message=of Nineteen City Churches_ (P. S. King & Son, Ltd.). to
00:52:06 JavaScript exception: KoLmafia error: Invalid extra field: ' Son, Ltd.).'; no value supplied.
00:52:06 
00:52:06  at file:/var/jenkins_home/workspace/KoLMafia%20Relay/scripts/phccs/phccs_gash.js:2606 (anonymous)
00:52:06  at file:/var/jenkins_home/workspace/KoLMafia%20Relay/scripts/phccs/phccs_gash.js:369 (withProperties)
00:52:06  at file:/var/jenkins_home/workspace/KoLMafia%20Relay/scripts/phccs/phccs_gash.js:379 (withChoices)
00:52:06  at file:/var/jenkins_home/workspace/KoLMafia%20Relay/scripts/phccs/phccs_gash.js:382 (withChoice)
00:52:06  at file:/var/jenkins_home/workspace/KoLMafia%20Relay/scripts/phccs/phccs_gash.js:2605 (smokeEmIfYouGotEm)
00:52:06  at file:/var/jenkins_home/workspace/KoLMafia%20Relay/scripts/phccs/phccs_gash.js:4917 (main)
horrible-little-slime commented 1 month ago

Should be resolved now