horriblename / hyprgrass

hyprland plugin for touch gestures
BSD 3-Clause "New" or "Revised" License
225 stars 7 forks source link

Build fails #107

Closed FrancescoCaracciolo closed 1 month ago

FrancescoCaracciolo commented 3 months ago

I can't manage to build this plugin on current Hyprland version.

Hyprland version (Arch Linux Hyprland package):

Hyprland, built from branch v0.38.1-b at commit 360ede79d124ffdeebbe8401f1ac4bc0dbec2c91  (props: bump ver to 0.38.1).
Date: Sat Apr 6 14:24:13 2024
Tag: v0.38.1

Adding it with hyprpm:

hyprpm add https://github.com/horriblename/hyprgrass                                                                                                                                    0 (53.228s) < 23:02:49
✔ adding a new plugin repository from https://github.com/horriblename/hyprgrass
  MAKE SURE that you trust the authors. DO NOT install random plugins without verifying the code and author.
  Are you sure? [Y/n] 

 → Cloning https://github.com/horriblename/hyprgrass                                                                                                                                                              
✔ cloned                                                                                                                                                                                                          
✔ found hyprload manifest                                                                                                                                                                                         
✔ parsed manifest, found 1 plugins:                                                                                                                                                                               
 → hyprgrass by horriblename version 0.6.0                                                                                                                                                                        
✔ Hyprland headers OK                                                                                                                                                                                             
 → Building hyprgrass                                                                                                                                                                                             
✖ Plugin hyprgrass failed to build.                                                                                                                                                                               

✔ all plugins built                                                                                                                                                                                               
✔ installed repository                                                                                                                                                                                            
✔ you can now enable the plugin(s) with hyprpm enable                                                                                                                                                             
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━  5 / 5  Done!    

installing manually, it gives this error on ninja -C build

ninja: Entering directory `build'
[11/13] Compiling C++ object src/libhyprgrass.so.p/GestureManager.cpp.o
FAILED: src/libhyprgrass.so.p/GestureManager.cpp.o 
c++ -Isrc/libhyprgrass.so.p -Isrc -I../src -Isubprojects/wf-touch -I../subprojects/wf-touch -I/usr/include -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/hyprland/protocols -I/usr/include/hyprland/wlroots -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -std=c++23 -fPIC -DWLR_USE_UNSTABLE -MD -MQ src/libhyprgrass.so.p/GestureManager.cpp.o -MF src/libhyprgrass.so.p/GestureManager.cpp.o.d -o src/libhyprgrass.so.p/GestureManager.cpp.o -c ../src/GestureManager.cpp
../src/GestureManager.cpp: In member function ‘bool GestureManager::handleWorkspaceSwipe(GestureDirection)’:
../src/GestureManager.cpp:248:9: error: base operand of ‘->’ is not a pointer
  248 |         ->m_vRenderOffset.getConfig()
      |         ^~
../src/GestureManager.cpp:251:9: error: base operand of ‘->’ is not a pointer
  251 |         ->m_vRenderOffset.getConfig()
      |         ^~
[12/13] Compiling C++ object src/libhyprgrass.so.p/main.cpp.o
ninja: build stopped: subcommand failed.
ahzay commented 3 months ago

Hey,

I've tracked this down to the following commit (I hope, I'm new to this).

Will try fixing now.

ahzay commented 3 months ago

I have created the PR that should fix this, @horriblename tell me if I've done anything wrong.

horriblename commented 1 month ago

should be fixed