search

horriblename / hyprgrass

hyprland plugin for touch gestures
BSD 3-Clause "New" or "Revised" License
268 stars 11 forks source link

HyprlandAPI Breaking Change Fix #112

Closed nine7nine closed 5 months ago

nine7nine commented 5 months ago

Callbacks need more adjustments as of: https://github.com/hyprwm/Hyprland/commit/e91513a5e8953cfbb69320d94e495ccf2d4d58f3

Tested on my end: Hyprgrass Plugin loads and works as expected with this change.

nine7nine commented 5 months ago

Hey @horriblename. More breakage in HyprlandAPI for plugins.

You can check the 'official' hyprland-plugins they've made similar adjustments, as did KZDKM/Hyprspace, which I used as references to fix your plugin. eg: https://github.com/KZDKM/Hyprspace/commit/983cb8d324e7495e0514820768cbdcecebc5bd2b

I think your nix build test fails -- because you probably need to update nix stuff against current hyprland/main ... unfortunately, I can't test that: I don't use nix

horriblename commented 5 months ago

LGTM will update nix later, thanks!

nine7nine commented 5 months ago

Not a problem at all. Glad to help out!

btw, that hyprpm: pin_commits[] commit will allow versioning / building against different releases/commits of Hyprland -- so that should ensure no one, regardless of hyprland version, will have any trouble using hyprpm to build hyprgrass.

I only just found out about that: so that is why I added the commit in.