search

horses-eating-turnips / turnip

OpenSourcery's Drupal starter kit, with a focus on developer collaboration and reusable code.
http://www.opensourcery.com
GNU General Public License v3.0
25 stars 4 forks source link

Use navbar module instead of core toolbar. #28

Closed adamdicarlo closed 10 years ago

adamdicarlo commented 10 years ago

Navbar just went into beta! Breakpoints comes along for the ride - navbar requires it.

jhedstrom commented 10 years ago

Does this module require permissions to use? Those should be updated in os_base if so.

adamdicarlo commented 10 years ago

@jhedstrom Good catch, thanks. It's just one permission, which I've added to this PR. I have not removed any permissions (like toolbar's)--okay to keep that there?

jhedstrom commented 10 years ago

Yeah, it should be ok to keep the toolbar perms there so long as the toolbar module isn't declared as a dependency.

One last question, I'm guessing the Breakpoints module just allows a theme to define breakpoints that other modules can react to, and it won't be at odds with the singularity work happening in Bedrock?

adamdicarlo commented 10 years ago

@anniegreens Could you weigh in, here? Thought about Breakpoints integration at all? I think navbar uses breakpoints as an API for its JavaScript to determine when to switch layouts....

anniegreens commented 10 years ago

If I'm understanding this correctly, I don't think there should be any interference. We would want the breakpoints to match up though. That's how I've done it with the picture module in the past.

jhedstrom commented 10 years ago

:+1: merge away.