search

horses-eating-turnips / turnip

OpenSourcery's Drupal starter kit, with a focus on developer collaboration and reusable code.
http://www.opensourcery.com
GNU General Public License v3.0
25 stars 4 forks source link

Rebuild backup #34

Closed jhedstrom closed 10 years ago

jhedstrom commented 10 years ago

What do folks think of adding a backup should the build fail? The dangers here are if somebody doesn't realize the build failed and goes to deploy to production or some such.

mpgeek commented 10 years ago

I like this cause it allows us to keep working locally if github is no worky. And, if we are all following the rules and executing rebuild just prior to deploying, the error message should alert us to the issue, no?

mariacha commented 10 years ago

Gotta say I probably won't notice the error message. Could we make it a question: "Build failed. Restore from backup? (Y/N)" So if I wandered away during a build it would be obvious that something was wrong?

anniegreens commented 10 years ago

Yeah. I like the idea of a question too.

jhedstrom commented 10 years ago

Problem with a question is infinite hang time upon failure on Jenkins...i suppose a flag to specify no backup would work for that.

jhedstrom commented 10 years ago

Ok, the script will now prompt prior to restoring. This can be bypassed either using --no-backup to skip backup entirely, or using --backup to backup and restore without prompting.

jhedstrom commented 10 years ago

Any remaining concerns on this? Otherwise I'll merge.