horses-eating-turnips / turnip

OpenSourcery's Drupal starter kit, with a focus on developer collaboration and reusable code.
http://www.opensourcery.com
GNU General Public License v3.0
25 stars 4 forks source link

OS-ACE Integration #36

Closed mpgeek closed 10 years ago

mpgeek commented 10 years ago

First swing at getting OS-ACE involved with spinning up sites. I've tested this as far as pulling down Turnip, generating the install profile, spinning up the theme, installing the site, logging in, choosing the newly generated theme as default. There are no errors, the site loads normally, and it looks like we have the base css from alphecca/bedrock. From that point it looks like we could probably use some default panels config cause there's nothing on the page except for a not found message and a link.

In any case, further testing in other peeps' environments would probably be good to make sure nothing is awry in the basic workflow of generating a Turnip site utilizing OS-ACE. Also, i didn't add the Grunt integration to this version of things, as I'm not sure who besides me wants to use it.

So, at this point it's really just evaluating whether or not Turnip still works as expected with the integration, and deciding if we need more initial config to make it useful. The Grunt integration would also be another thing to decide on as well.

Please test.

anniegreens commented 10 years ago

I use grunt as well. We may want to standardize this as I've seen differences in CSS generated from Grunt vs compass compile. Not sure why...

Great job Eric!!!

Anne

On Jan 31, 2014, at 6:07 PM, Eric Paul notifications@github.com wrote:

First swing at getting OS-ACE involved with spinning up sites. I've tested this as far as pulling down Turnip, generating the install profile, spinning up the theme, installing the site, logging in, choosing the newly generated theme as default. There are no errors, the site loads normally, and it looks like we have the base css from alphecca/bedrock. From that point it looks like we could probably use some default panels config cause there's nothing on the page except for a not found message and a link.

In any case, further testing in other peeps' environments would probably be good to make sure nothing is awry in the basic workflow of generating a Turnip site utilizing OS-ACE. Also, i didn't add the Grunt integration to this version of things, as I'm not sure who besides me wants to use it.

So, at this point it's really just evaluating whether or not Turnip still works as expected with the integration, and deciding if we need more initial config to make it useful. The Grunt integration would also be another thing to decide on as well.

Please test.

You can merge this Pull Request by running

git pull https://github.com/opensourcery/turnip os-ace-integration Or view, comment on, or merge it at:

https://github.com/opensourcery/turnip/pull/36

Commit Summary

Add init-theme script for initial OS-ACE integration. Basic readme updates for OS-ACE integration. File Changes

M README.md (7) A bin/init-theme (81) Patch Links:

https://github.com/opensourcery/turnip/pull/36.patch https://github.com/opensourcery/turnip/pull/36.diff — Reply to this email directly or view it on GitHub.

mpgeek commented 10 years ago

Still some missing stuff here, don't merge please.