Closed anniegreens closed 10 years ago
I wonder if an os_theme feature would make sense, so any given project can en/disable the Three/Four Horses stack easily?
Well, it isn't necessarily en/disabling the stack. They're just theme related modules, listed on the Aurora Documentation (http://snugug.github.io/Aurora/modules/). The only one that could really be disabled would be Bedrock, and I don't see it likely that we'd disable that. However, I do like the idea of a theme-only feature such as os_theme.
Ahh, but I do see the use case for building with an alternate theme. Is that what you mean @mpgeek ?
@anniegreens i was thinking more for keeping components modular, the immediate goal is to streamline theming, so NOT using the stack seems like a non-factor right now. I just think its easier to jump in when things are broken down into digestible units (as opposed to a monolithic makefile + base_feature.
Yeah, agreed. It looks like @jhedstrom created a Bedrock FPP feature in the Frontend package. Perhaps he can weigh in on extending that with the creation of a 'parent' feature that includes it as a dependency along with all the other theme-related modules. It looks like nothing else depends on it right now. I'd like us to come to a consensus before I move forward with a new feature on Edison, as I'd like to mark it for backporting.
The Aurora stack requires/works with some modules that need to be enabled by the core feature. Can we include these in < project >_core feature? Seems like the best place, unless we want to create a theme feature to go with theme.make.