search

horses-eating-turnips / turnip

OpenSourcery's Drupal starter kit, with a focus on developer collaboration and reusable code.
http://www.opensourcery.com
GNU General Public License v3.0
25 stars 4 forks source link

bin/rebuild should wait for a successful build before destroying drupal directory #46

Closed jessehs closed 10 years ago

jessehs commented 10 years ago

I'm typing this as I'm waiting for a build to complete locally. (I've got down time.) If we ran the drush make process in a temporary directory like 'building' or something, then I could still do development tasks using the existing 'drupal' directory. When the build is complete, the rebuild script could then destroy the existing drupal directory and move the newly built one into place over it.

mpgeek commented 10 years ago

I wonder if just doing a temporary git clone of the needed components (into the right directory, obvi) would be faster for this? We just need the correct directory structure to be in place when the compass extension spins up the theme. Subsequent rebuild could then just overwrite it.

jhedstrom commented 10 years ago

The script already makes a backup, so it might be possible to do some more switching. The main reason for the immediate destruction (eg, the --clean flag) is for phpcs tests on Jenkins (so it doesn't run them against contrib).

mpgeek commented 10 years ago

I just used drush make with the --projects an d --libraries switches to just build alphecca and bedrock. Fixed here: https://github.com/opensourcery/turnip/commit/9e4465037e178d85429a7351b97bee57731b98eb