search

horst3180 / arc-firefox-theme

Arc Firefox Theme
Mozilla Public License 2.0
938 stars 48 forks source link

Multiprocess windows (electrolysis) unsupported #106

Open joshuap opened 7 years ago

joshuap commented 7 years ago

In about:support, the Multiprocess Windows option is disabled with any of the Arc themes active. When I switch back to the default Firefox theme Multiprocess Windows are enabled again. Electrolysis support is really important as it significantly speeds up Firefox.

Is this something which could be addressed? Thanks!

Booteille commented 7 years ago

Is there any plan to fix this?

horst3180 commented 7 years ago

Hmm yeah, I don't know how to fix this. I marked the addon as "multiprocessCompatible" so it should work according to this. Maybe it's a Firefox bug affecting only themes, since themes are a special variant of addons.

Booteille commented 7 years ago

When I am using another theme (japanese_sky01), e10s is enabled. So it looks like some themes are able to work with e10s. I don't know if it helps you to find out what is wrong.

horst3180 commented 7 years ago

That's a "lightweight theme" and it works entirely different from a complete theme like this one.

Booteille commented 7 years ago

Okay. That's what I thought but wasn't sure about.

Thanks.

ArchangeGabriel commented 7 years ago

Hum… I using this theme and have Multiprocess Windows here. Not sure what it doesn’t work for your guys.

Booteille commented 7 years ago

I tried to deactivate all my addons except Arc and I still can't use e10s.

I am on Linux Mint 18.1 and firefox 52.0.1.

hoelzro commented 7 years ago

I just discovered this and dug into the code to figure out why; apparently Firefox will only treat regular extensions as e10s-compatible: https://dxr.mozilla.org/mozilla-central/rev/37a5b7f6f101df2eb292b1b6baaf1540c9920e20/toolkit/mozapps/extensions/internal/XPIProvider.jsm#1238

I'm going to reach out to Mozilla and see if that choice was deliberate or just oversight.

ghost commented 7 years ago

According to the developer of FT DeepDark, this is a preventive measure applied by Mozilla to avoid compatibility issues. At least till Firefox 57.

For now, I have force enabled Electrolysis by going to about:config and adding a new boolean browser.tabs.remote.force-enable Everything seems to work fine

Booteille commented 7 years ago

Your solution seems to work for me, @ninjagoat. Thanks.

ghost commented 7 years ago

You're welcome @Booteille

But also, make sure there are no other incompatible add-ons installed. Force enabling Electrolysis could possibly lead to problems. You can use this add-on to check multiprocess compatibility.

Booteille commented 7 years ago

Sure. I already disabled every incompatible addons and everything work fine actually.