search

horst3180 / arc-firefox-theme

Arc Firefox Theme
Mozilla Public License 2.0
938 stars 48 forks source link

Compatibility with Photon UI #120

Open null-von-sushi opened 7 years ago

null-von-sushi commented 7 years ago

Firefox is going to get a new UI, and it would be nice to see Arc support it.

Currently one of the problems I noticed is that the page actions button does not display properly (top one is Arc Dark, bottom one is the default theme)

theme

ArchangeGabriel commented 7 years ago

Two things:

  1. Photon will land when then won’t be working anymore (hence the LEGACY you’re seeing on those screenshots). So support for Photon makes no sense, at least in the current status of it.

  2. The issue you’re seeing is not directly related to Photon (you don’t have Photon enabled on those screenshots), it’s a change that landed in Nightly where the Reload/Stop button was moved outside of the navbar and a new sharing button replaced it there (but this change is requested by Photon indeed). So both have new name/path, which are not provided by the Arc Theme. I’m not sure whether this could be fixed without breaking stable, I don’t know enough about theming. But they can probably be fixed in contrary to 1.

ArchangeGabriel commented 7 years ago

Also this is a duplicate of https://github.com/horst3180/arc-firefox-theme/issues/117.

Noammac commented 7 years ago

There seem to be new Photon problems. With arc theme: image Without arc theme: image

ArchangeGabriel commented 7 years ago

Yes, they have redone the whole hamburger menu. So this is expected (on a personal side, they also changed the downloads icon, and I absolutely do not like it w.r.t. the previous one)…

As I’ve said before, supporting the new UI is not really doable right now, since this UI will land in 57 when support for theming will at least change a lot, at worst disappear (hopefully temporarily).

Noammac commented 7 years ago

I see, so there's no way to fix the overflow menu right now.

ArchangeGabriel commented 7 years ago

I’ve got more news from the Mozilla stand at the RMLL. They said full theming won’t be supported at all starting with 57, only personas will remain.

Sad news for us here… :(

jadenPete commented 7 years ago

What the hell Mozilla?

ArchangeGabriel commented 7 years ago

They said that full theme are only used by a very tiny fractions of the users, so they are even less wanting to spend time supporting this that they do for extensions.

lokesh-krishna commented 7 years ago

Just wanted to say that the latest nightly looks gorgeous when just using the Arc theme as the GTK theme. I was so sad about losing theming with Firefox 57 but if this is how good it looks and how well it integrates with the GTK theme then I don't think this is going to be as much of a loss it might have been otherwise.