search

horst3180 / arc-firefox-theme

Arc Firefox Theme
Mozilla Public License 2.0
938 stars 48 forks source link

Some icons appears in duplicate with Firefox 55 #131

Open baydam opened 7 years ago

ghost commented 7 years ago

Second this. Note the duplicated Pocket icon, the duplicated forward backward buttons and lack of refresh button.

screenshot from 2017-08-10 10-22-23

Narrat commented 7 years ago

And in the menu the duplicated Sync-Panel

ghost commented 7 years ago

The sync duplication is bug #123, and may be unrelated. I noticed that sync was not functioning properly (with duplicated icon in sync panel) on 54 before I updated to 55, and the other weirdness occurred after upgrade to 55.

Narrat commented 7 years ago

Hm, okay. I just noticed it with FF55, but possible I overlooked it. Since I only looked for quirks after noticing issues Forward/Backward and reload. Thanks for the pointer

Siphonay commented 7 years ago

I face those issues too, seems that the theme engine have changed a little with Firefox 55, meaning Arc requires an update. I've changed to the Compact Dark theme until then

ArchangeGabriel commented 7 years ago

This is partly https://github.com/horst3180/arc-firefox-theme/issues/121 and in the end mostly https://github.com/horst3180/arc-firefox-theme/issues/120. Please read the thread if you want more details, but else: TL;DR: Firefox themes are dead.

sirfz commented 7 years ago

There was an issue with duplicate info in Firefox 54 (#124) but there hasn't been a FF 54 arc-theme release since 53 so it seems development hasn't been active since then.

ArchangeGabriel commented 7 years ago

@sirfz Sorry if I wasn’t clear: it’s normal that there hasn’t been any active development, because they can’t be any, Firefox REMOVED support for theming.

ArchangeGabriel commented 7 years ago

(To be more precise, they’re removing parts by parts)

sirfz commented 7 years ago

@ArchangeGabriel from what I understand, that applies to the coming Firefox 57 release which features the new GUI (Photon UI) but not the current release. Also, the desktop Arc-theme hasn't been active either horst3180/arc-theme#810

ArchangeGabriel commented 7 years ago

@sirfz No, they’re landing Photon UI parts by parts starting from Firefox 54. In 57 what happens is that you can’t even try to load another theme. Currently you still can, but they might be broken depending on which elements they are theming.

jgillich commented 7 years ago

FWIW they blogged about this in February: https://blog.mozilla.org/addons/2017/02/24/improving-themes-in-firefox/