horst3180 / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
8.28k stars 610 forks source link

XFCE windows can only be resized from the top #361

Closed KazroFox closed 8 years ago

KazroFox commented 8 years ago

I think the problem is that XFCE uses the window borders to determine where the grab handle should appear, and this theme seems to have zero-width borders. The top and the two top corners still work thanks to the decoration.

I don't know if there's a way to work around this, but as-is it's painful to use.

horst3180 commented 8 years ago

Hmm yeah that's a bit of a problem. I'll try to find a solution.

eXistenZNL commented 8 years ago

You can easily resize windows in XFCE with alt-rightclick anywhere in the window, grab near the edge or corner of the window you want to resize and drag the mouse.

Source: running Xubuntu 15.10 with Arc theme myself :)

ghost commented 8 years ago

Yes mah17, please use this combination (alt + right mouse key) - arc is the only borderless theme I lkie :-)

KazroFox commented 8 years ago

Whether an option be made to switch between bordered and borderless themes, or some other solution, its a bit unreasonable to expect all users to be familiar with obscure shortcuts in order to perform a basic function like resizing the window.

Maybe we need to file a bug upstream and get XFWM to allow grab handles to appear without window borders, but as-is this bug makes it painful to use as a XFWM theme for most users.

eXistenZNL commented 8 years ago

I don't see it as a flaw in the Arc theme itself, nor in XFCE, because basically you choose to use the borderless Arc theme but then feel it's a bug not being able to resize by dragging the borders.

The fact that XFCE has this handy grab 'n resize shortcut makes it possible to still enjoy Arc without having problems with the risizing of the windows, which is a bonus compared to other window managers imho.

If you don't like a borderless theme, then why would you use it in the first place?

crocket commented 8 years ago

I stumbled upon this bug today. This bug is still present.

I didn't know arc was a borderless theme. The theme wasn't advertised as a borderless theme. I use arc because the alternatives on gtk 3.20 are plain ugly right now. Not many themes have been ported to gtk 3.20. I used to be on greybird before gtk 3.20 broke it.

I also didn't know the alt+right mouse click shortcut before I read this issue.

eXistenZNL commented 8 years ago

Regarding borderless themes: I'm not sure if it should be advertised as one, it just looks like is has no borders so that's why I called it a borderless theme. Made sense to me :)

crocket commented 8 years ago

Most users including me just want themes to work and look good, so they don't notice that a certain theme has borders or no borders. Until I met this issue, I didn't know there was such a thing as a borderless theme. I thought themes couldn't control window borders.

linuxlite commented 8 years ago

Would also like to see all windows can be resized from the bottom, this is common feedback from our users. Especially the terminal (lxterminal).

blackhole89 commented 8 years ago

Just ran into this and wound up patching it for myself by setting borders back to 1px. Is there perhaps some way you could add the border but make it render transparent (or the appropriate opacity of the shadow gradient for its location)?

linuxlite commented 8 years ago

@blackhole89 how did change it? Which files and code did you use? Thank you.

blackhole89 commented 8 years ago

@linuxlite In all /usr/share/themes/Arc-/metacity-1/metacity-theme-.xml: In all instances of <frame_geometry> that have name="normal": Change value of all instances of that have name="left_width", "right_width" or "bottom_height" from 0 to 1.

linuxlite commented 8 years ago

@blackhole89 no luck here with those changes in all those files. Example of a block I changed:

<frame_geometry name="normal" title_scale="medium" rounded_top_left="1" rounded_top_right="1">
    <distance name="left_width" value="1" />
    <distance name="right_width" value="1" />
    <distance name="bottom_height" value="1" />
    <distance name="left_titlebar_edge" value="2"/>
    <distance name="right_titlebar_edge" value="2"/>
    <distance name="title_vertical_pad" value="3"/>
    <border name="title_border" left="10" right="10" top="3" bottom="3"/>
    <border name="button_border" left="3" right="3" top="0" bottom="0"/>
    <aspect_ratio name="button" value="1.0" />

</frame_geometry>
blackhole89 commented 8 years ago

That does look correct. Did you edit multiple blocks like that in all three files? Also, this may be a silly question, but did you restart the window manager/reselect the window border theme in the Gtk2 appearance settings? (I'm not sure what is sufficient to trigger it reacting to a change on disk.)

I've tested the changes with Arc-Darker and both MATE's metacity fork (marco) and compiz's gtk window decorator.

linuxlite commented 8 years ago

@blackhole89 would you mind sharing all 3 of your metacity-theme files? Thank you.

ali1234 commented 8 years ago

Just FYI: X11 Windows can't have fully transparent areas which are still interactive unless you have full RGBA compositing. That means Xfwm4 can't implement an extra transparent resize handle around windows unless it drops support for non-composited displays, or maintains two radically different code paths for theme drawing.

kopr12 commented 8 years ago

Had the same problem, but in MATE , anyways ... what blackhole89 suggested as a fix worked.

horst3180 commented 8 years ago

Should be fixed now.