search

horst3180 / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
8.27k stars 611 forks source link

Bundle Plank theme in GTK theme folder #570

Open cassidyjames opened 8 years ago

cassidyjames commented 8 years ago

Plank has a Gtk+ theme option where it looks for a plank/dock.theme file in the active GTK theme's folder. Moving Arc's Plank theme into that location would mean that Plank's Gtk+ option would Just Work:tm:, especially on OSes like elementary OS where the Gtk+ option is set by default.

HEXcube commented 8 years ago

This is similar to the way Unity loads it's theme from the unity subfolder inside the current GTK theme. And Arc already has a Unity theme in the common folder. So, if the Plank theme dock.theme, currently in an extra folder, is also moved to a plank subfolder in the common folder, it'd enable 'out of box' theming support for Plank like @cassidyjames pointed out :relaxed:

Bundling Plank theme inside would also remove the requirement to package it separately. And we at Ubuntu Budgie, would benefit from not having to submit another package to Debian just for the Plank theme :grin:

fossfreedom commented 8 years ago

@HEXcube and @cassidyjames - from a Debian (and Ubuntu 16.10) point of view - I've added a change to the arc-theme debian package to install the 'extra - Arc Plank' theme to 'plank/dock.theme' for each of the 3 arc themes.

HEXcube commented 8 years ago

Happy to let u guys know @fossfreedom 's package update has made it into Debian sid repo a few hours ago, and thereby got sync'd into Ubuntu 16.10 repos too! :smiley: This is the commit by @fossfreedom that bundles Plank theme: add packaging for plank gtk+ option . But if the Plank theme is moved directly into a plank subfolder in common folder here in this upstream repo, then the bundling could be made simpler. :grin: