horst3180 / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
8.28k stars 612 forks source link

HiDPI version for xfce #691

Open MoriTanosuke opened 7 years ago

MoriTanosuke commented 7 years ago

I'm using XFCE on a Dell XPS15 with a HiDPI display and I'm constantly searching for themes that support this. I found your theme via https://github.com/af2005/Arc-theme-HiDPI but noticed that the fork is no longer updated.

I tried to add a couple lines to generate HiDPI assets, but I'm not familiar with autoconf and automake, so I struggled and failed to add a completely new variant of the theme for XFCE. At the moment I just copied everything manually into my themes folder and am using the larger assets on my installation.

Maybe you can have a look at my branch at https://github.com/MoriTanosuke/arc-theme/tree/hidpi and give me some hints what I have to add to generate a new folder Arc-HiDPI for the new assets? That would be really helpful. :smile:

geokapp commented 7 years ago

Hi, I had exactly the same problem with XFCE and high DPI support. I also tried Arc-theme-HiDPI with no luck.

So, because I fall in love with the Arc theme, I tried to resolve this problem by creating arc-variants that produces different variants of the vanilla Arc theme. It currently produces blue, red, green, and brown color variants and their respective high DPI versions. I have made minor modifications to some elements (e.g., title buttons), but the tool supports the option to preserve the original elements.

AntouanK commented 7 years ago

@MoriTanosuke are you still working on this?

MoriTanosuke commented 7 years ago

Not really, but @geokapp https://github.com/geokapp/arc-variants looks like what I wanted. :)

geokapp commented 7 years ago

Another option is to clone the Arc theme and modify the scripts that render the images:

xfwm4: common/xfwm4/render-assets.sh

add the option --export-dpi=DPIVALUE (e.g., 140) to the inkscape commands.

gkt2: common/gtk-2.0/render-assets.sh

add the option --export-dpi=DPIVALUE (e.g., 140) to the inkscape commands.

gtk3:

common/gtk-2.0/render-assets.sh

add the option --export-dpi=DPIVALUE (e.g., 140) to the first inkscape command.

After that, you can should run these scripts to produce the new images and reinstall the theme.

AntouanK commented 7 years ago

@geokapp Thanks, I'll give it a try.

unhammer commented 6 years ago

Note that after adding the --export-dpi="${DPIVAL}" \ lines to common/{xfwm4,gtk-2.0,gtk-3.0/3.22}/render-assets.sh, it's not enough to sudo make install; you'll have to first force a remake of the assets:

rm -f common/{xfwm4,gtk-2.0,gtk-3.0/3.22}/assets{,-dark}/*.png
for d in common/{xfwm4,gtk-2.0,gtk-3.0/3.22}; do ( cd "$d" && ./render-assets.sh );done

It looks like the gtk-3.0 file already creates a HiDPI version of each asset, named e.g. titlebutton-minimize-active-dark@2.png instead of titlebutton-minimize-active-dark.png, but that doesn't help xfce users. (Also, does gtk3 scale down those things? 180 is too high for my laptop)