horst3180 / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
8.28k stars 608 forks source link

Synapse: Background color on selected items #71

Closed slosd closed 9 years ago

slosd commented 9 years ago

In the application launcher "synapse" the background for selected items is missing: Synapse launcher

As a reference, this is what it looks like with the standard Ubuntu (Ambiance) theme: Synapse launcher with Ambiance

baurigae commented 9 years ago

I tried it too - Virgilio theme, right? :) and my first instinct was to hack the Synapse theme in question, considering it's niche and barely maintained software and the author of Arc can't really be expected to cover every nook and cranny... sadly I have no idea where Synapse theme configs are stored.

slosd commented 9 years ago

I had a look at the synapse code and the Ambiance stylesheets. Synapse simply sets the state of its items to selected and in Ambiance there is a general rule which defines the colors for selected elements:

*:selected,
*:selected:focused {
    background-color: alpha (@selected_bg_color, 0.9);
    color: @selected_fg_color;
}

This is missing in the authors themes (not just Arc).

horst3180 commented 9 years ago

Should be fixed now. I set the wildcard only for the synapse window, because wildcards are bad:

SynapseGuiViewDefault *:selected { background-color: $selected_bg_color; }
johnfraney commented 9 years ago

I'm still seeing this issue wtih Arc and Arc-Darker.

Arch Linux, 4.2.1 AUR gtk-theme-arc-git package, 267.6471abc-1 @ 2015-09-28 XFCE 4.12

Is there anything I can do to troubleshoot?

horst3180 commented 9 years ago

Yup, I overlooked something. Should be fixed with https://github.com/horst3180/Arc-theme/commit/cad1815b0aaf34e5f335735ad9361c71ae2e9797.

johnfraney commented 9 years ago

@horst3180 That did it. Thanks!

entodoays commented 8 years ago

I still have this problem on Arch Linux, Gnome 3.20, Synapse 0.2.99.2 and gtk-theme-arc-git gtk498.46a232e-1.

horst3180 commented 8 years ago

GTK 3.20 broke my workaround, i can't fix it anymore. This should be reported upstream.

Edit: With upstream I mean synapse.

entodoays commented 8 years ago

Bug report submitted: https://bugs.launchpad.net/synapse-project/+bug/1570442

somas95 commented 8 years ago

Any workaround? In synapse seems that nobody is working in this bug...is so frustrating

entodoays commented 8 years ago

As a workaround edit the synapse.desktop file. Find the Exec=synapse line and change it to Exec=env GTK_THEME=Adwaita:dark synapse

somas95 commented 8 years ago

I tried that, and is a good idea, but then, any program launched by synapse inherit that theme and color variant

entodoays commented 8 years ago

If you prefer staying with a light theme, then you can install the Numix theme and use that as the GTK+ theme. You'll still the inheritance issue but you'll have a light theme.

somas95 commented 8 years ago

And I think, if this issue doesn't happen with Numix, why is an synapse issue and not an Arc issue?

entodoays commented 8 years ago

I cannot answer your question. It is an issue with Adwaita light and Arc but not with Numix.

chopfitzroy commented 7 years ago

Has there been any update on this?

zetaverse commented 7 years ago

Hi guys, I am facing this issue after upgrading to 16.10. I played around with other themes like Numix and Synapse displays it properly, like you guys said but in Arc, Greybird etc, it doesn't work. I have switched to Numix for now.

matejmosko commented 7 years ago

@horst3180, I confirm this issue reappears on ubuntu 16.10 with all variants of arc theme from ubuntu's repo. synapse

nodiscc commented 7 years ago

I can reproduce this issue with arc-theme 20161119-1 from official Debian Stretch repositories:

synapse

As said above and in https://bugs.launchpad.net/synapse-project/+bug/1570442 a workaround is to launch synapse with GTK_THEME=anothertheme synapse (or edit the .desktop launcher) but all applications launched from Synapse will inherit that theme.

@horst3180 can this be fixed in arc-theme? Or does something need fixing in synapse?

By the way there is an actively maintained fork of synapse at https://github.com/MichaelAquilina/synapse-project/ but I don't know how/if they cooperate and if @MichaelAquilina would fix this bug, if that would result in the bug being fixed in the Debian package, which uses the original launchpad project.

Thanks for Arc, best looking theme in years.

TheBabu commented 6 years ago

I too have the same problem... I hope someday that there would be a simple fix... or at least a workaround..

fluffylynx commented 6 years ago

I use the "Greybird" theme and had this problem. The snippet provided above by @slosd worked after a few tweaks. Add the following to the end of gtk-3.0/gtk-contained.scss and recompile with SASS.

*:selected,
*:selected:focused {
    background-color: $selected_bg_color;
    color: $selected_fg_color;
}
NicoHood commented 6 years ago

@fluffylynx Please report this issue along with the fix as a PR on the new fork.