search

horst3180 / arc-theme

A flat theme with transparent elements
GNU General Public License v3.0
8.28k stars 612 forks source link

Notification Count style #78

Closed wallisch closed 9 years ago

wallisch commented 9 years ago

The notification count badge (?) on elementary OS shown in Plank really bugs me, because it doesn't fit to the rest of the theme. It seems to change if i switch to other themes (elementary, numix).

I tried to change it manually, but i couldn't find out how it's called ...

GitHub Logo

horst3180 commented 9 years ago

I don't know where this badge gets it's style from, but I don't think it's the theme. I searched the elementary and numix themes for this and couldn't find anything. What application is this? And is it the only application with this badge?

wallisch commented 9 years ago

The application is "Telegram", but Thunderbird also displays this bagde.

I made a couple of screenshots with different themes to illustrate the issue: http://imgur.com/a/7n11U

How should this normally look on elementary?

horst3180 commented 9 years ago

I think Plank reads the @selected_bg_color variable from the current gtk theme and shifts its hue until the blue becomes red. Then it uses this color to draw the badge gradient. The whole thing is hardcoded and not configurable without changing the source code. This also explains why the badge becomes green with numix, since numix uses a red color as @selected_bg_color. It seems that this algorithm produces ugly gradients for certain colors, but I can't do anything about it. I have problems like this all the time with elementary apps. They're just too tightly integrated with the default theme.

wallisch commented 9 years ago

Why on earth would someone do that instead of making it an option in the plank theme config files... Anyway, thanks for looking into it.

Great Theme by the way!

Edit: Issue exists since 2 years, but apparently it doesn't annoy anyone https://bugs.launchpad.net/plank/+bug/1156159