Firefox 57.0.1 with CSD on makes window buttons double up

[mymindstorm]

• Distribution (with version): Fedora 27
• Desktop environment: GNOME 3.26.2
• Arc version: 20170302
• GTK+ 3 version: 3.22.26
  • Murrine engine version: 0.98.2
  • gnome-themes-standard version: 3.22.3
• Installation method: package

With Firefox 57.0.1 one Fedora 27 if you enable about:config setting widget.allow-client-side-decoration the window buttons double up / are miscolored.

Firefox	Normal

[NicoHood]

I do not even have this option widget.allow-client-side-decoration in my firefox. Why would you want to enable it? Also shouldnt it be the default by now that firefox supports gtk themes better?

[mymindstorm]

From what I'm aware it's still in testing and they moved the option to stable Firefox only in Fedora 27. In other distros you need to use the nightly build to get that option. See this article and this Reddit comment thread for proof that this option exists.

I use this option because I don't like the way it looks with the tab bar doubling the header bar size, and it just looks nicer in my opinion.

I'm assuming it eventually will be the default option once it's stable enough and gets out of nightly, so this is likely to just get reported again when that time comes.

[NicoHood]

Does it happen with other themes?

I am curious how the whole firefox looks. Wanna take a screenshot?

[mymindstorm]

It looks pretty great!

Arc:

Numix (hover color on close buttons are incorrect):

Adwaita:

Here is a picture with arc and the flag off for comparison:

[NicoHood]

@fossfreedom We should fix this, however I have no idea how.

@mymindstorm thanks for the pics, really looks nice.

[mymindstorm]

I've never worked with theming (and I'm not very good at CSS), so I'm not sure if this will help, but firefox classes the buttons as titlebar-min, titlebar-max, and titlebar-close. The icons are given toolbarbutton-icon

I haven't had any luck playing around with these and my usercrhome.css, and I'm not even sure if the same classes apply due to scoping.

[fossfreedom]

@mymindstorm @NicoHood that setting isnt in my Firefox 57.0.3 so I cannot reproduce.

To analyse the issue I would enable GTK Inspector - then activate it for Firefox - you can look a the CSS Node for the widgets and look at the Style that the widget uses. Then on the CSS pane you can fiddle with the CSS for that widget

https://wiki.gnome.org/Projects/GTK+/Inspector

[mymindstorm]

So it looks like everything is hidden away inside a MozContainer and it won't let me go any deeper than that.

[fossfreedom]

This sounds more like a bug with the current CSD implementation. Think CSD is experimental and you have to explicitly compile in this support. Suggest report it on the Firefox issue tracker

On 5 Jan 2018 22:47, "mymindstorm" notifications@github.com<mailto:notifications@github.com> wrote:

So it looks like everything is hidden away inside a MozContainer and it won't let me go any deeper than that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/horst3180/arc-theme/issues/862#issuecomment-355686318, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA8zkBJa7W_Jg-KBqjxt4UcHr3WRKzrHks5tHqZlgaJpZM4RUESQ.

[mymindstorm]

Found it: https://bugzilla.mozilla.org/show_bug.cgi?id=1408335

Patch author explains cause in comment 6:

It's caused by Gtk+ themes with a specific button.titlebutton theming.

For instance Arc-Dark defines:

.titlebar button.titlebutton.close, .titlebar button.titlebutton.maximize, .titlebar button.titlebutton.minimize { color: transparent; .... }

.titlebar button.titlebutton.close { background-image: -gtk-scaled(url("assets/titlebutton-close-dark.png"), url("assets/titlebutton-close-dark@2.png")); }

which means default Gtk+ titlebar button is transparent (invisible) and it's completely replaced by background-image.

[NicoHood]

horst3180 is inactive for a long time now. The arc theme is now maintained in this fork: https://github.com/NicoHood/arc-theme

Please close this issue, test the latest version of the fork and open a new issue on the fork if it still exists. Thanks.

[abihf]

Hi @NicoHood I enabled CSD in Firefox nightly in Archlinux, but there is no padding between tabs and top border. Is this expected?

I downloaded it from from heftig's repo, the version is 59.0a1 (2018-01-19).

[ArchangeGabriel]

@abihf Yes that is expected.

[ArchangeGabriel]

Or maybe not… It likely depends on several things, like window compositor and some settings.

[mymindstorm]

Fix pushed to upstream, in nightly