search

hortinstein / node-dash-button

A small module to emit events when an Amazon Dash Button is pressed
949 stars 94 forks source link

PR #23 not in latest version #28

Closed dangothemango closed 8 years ago

dangothemango commented 8 years ago

Hey,

Im currently working on expanding and improving the pizzadash project which uses this as a dependency. I just fixed a bug using the same solution as in error #14. Id like for the users to just use npm install but that does not yet include PR #23 so the error will still exist. Could you increment the version number and push to npm?

Dan

hortinstein commented 8 years ago

Yeah I will take care of it after work On Apr 29, 2016 2:11 PM, "Dan Gorman" notifications@github.com wrote:

Hey,

Im currently working on expanding and improving the pizzadash project which uses this as a dependency. I just fixed a bug using the same solution as in error #14 https://github.com/hortinstein/node-dash-button/issues/14. Id like for the users to just use npm install but that does not yet include PR #23 https://github.com/hortinstein/node-dash-button/pull/23 so the error will still exist. Could you increment the version number and push to npm?

Dan

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/hortinstein/node-dash-button/issues/28

dangothemango commented 8 years ago

awesome, thank you On Fri, Apr 29, 2016 at 2:28 PM Alex Hortin notifications@github.com wrote:

Yeah I will take care of it after work On Apr 29, 2016 2:11 PM, "Dan Gorman" notifications@github.com wrote:

Hey,

Im currently working on expanding and improving the pizzadash project which uses this as a dependency. I just fixed a bug using the same solution as in error #14 https://github.com/hortinstein/node-dash-button/issues/14. Id like for the users to just use npm install but that does not yet include PR #23 https://github.com/hortinstein/node-dash-button/pull/23 so the error will still exist. Could you increment the version number and push to npm?

Dan

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/hortinstein/node-dash-button/issues/28

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/hortinstein/node-dash-button/issues/28#issuecomment-215839764

hortinstein commented 8 years ago

taken care of! Thanks I appreciate the heads up!