hortonworks-spark / spark-llap

Apache License 2.0
101 stars 68 forks source link

added brackets to logical expression to correctly distinguish between… #274

Open takkarharsh opened 4 years ago

takkarharsh commented 4 years ago

issue : https://github.com/hortonworks-spark/spark-llap/issues/273

What changes were proposed in this pull request?

As a user if we add multiple filters with "or" operator on spark dataframe it should be enclosed properly with correct brackets but in the current version of hwc multiple filters are not enclosed with proper brackets for e.g. df = df.fiter("condition1 or condition2") df = df.filter("condition3 and condition4")

the resultant query created is as follows

(condition1) or (condition2) and (condition3) and (condition4) ideally it should be as follows ((condition1) or (condition2)) and ((condition3) and (condition4))

How was this patch tested?

manual tests

takkarharsh commented 4 years ago

https://issues.apache.org/jira/browse/HIVE-22154