hortonworks / streamline

StreamLine - Streaming Analytics
Apache License 2.0
164 stars 96 forks source link

manual kafka service add fails with protocol check #780

Closed HeartSaVioR closed 7 years ago

HeartSaVioR commented 7 years ago

WARN [22:27:48.346] [dw-33 - POST /api/v1/catalog/clusters/2/services/register/KAFKA] c.h.s.s.c.s.EnvironmentService - Protocol/Port information [SASL_PLAINTEXT://host1:port1,PLAINTEXT://host2:port2,SSL://host3:port3,SASL_SSL://host4:port4] for component KAFKABROKER doesn't seem to known format [([a-zA-Z]+)://[a-zA-Z0-9-\.]*:([0-9]+)]. skipping assignment...

Masked actual hosts and ports. It fails even with a single protocol.

HeartSaVioR commented 7 years ago

This is a bit complicated because of Ambari import. Ambari provides <protocol>://localhost:<port> so that was fairly easy, but not similar as above configuration.

HeartSaVioR commented 7 years ago

Thought about manual registration more, and I also found what I was missing: configuration file doesn't have default value hence and we can't get the default value anyway.

We need to define required fields for service and let user also input on registering. Since we add resource file for Hadoop / HBase / Hive in topology, we may not need to define required fields for those services, but need to define for others.

HeartSaVioR commented 7 years ago

Another issue is current implementation of Component. It contains host information as hosts, port, protocol, which can't handle above case. (different protocol and/or different port)

There're two ways of handle this case:

HeartSaVioR commented 7 years ago

Storm

Kafka

Druid

HeartSaVioR commented 7 years ago

785

HeartSaVioR commented 7 years ago

I think #792 (which addresses #785) also covers this.

HeartSaVioR commented 7 years ago

Relevant issue addressed this. Closing.