hortonworks / streamline

StreamLine - Streaming Analytics
Apache License 2.0
164 stars 96 forks source link

Revisit manual service registerer #785

Closed HeartSaVioR closed 7 years ago

HeartSaVioR commented 7 years ago

This issue addresses #780 and #781

Below content is copied from #780

This is a bit complicated because of Ambari import. Ambari provides ://localhost: so that was fairly easy, but not similar as above configuration.

Thought about manual registration more, and I also found what I was missing: configuration file doesn't have default value hence and we can't get the default value anyway.

We need to define required fields for service and let user also input on registering. Since we add resource file for Hadoop / HBase / Hive in topology, we may not need to define required fields for those services, but need to define for others.

Another issue is current implementation of Component. It contains host information as hosts, port, protocol, which can't handle above case. (different protocol and/or different port)

There're two ways of handle this case:

Storm

Kafka

Druid

HeartSaVioR commented 7 years ago

792

HeartSaVioR commented 7 years ago

792 was merged. Closing.