search

hossein-zare / react-native-dropdown-picker

A single / multiple, categorizable, customizable, localizable and searchable item picker (drop-down) component for react native which supports both Android & iOS.
https://hossein-zare.github.io/react-native-dropdown-picker-website/
MIT License
970 stars 294 forks source link

support a `modalAnimationType` prop #609

Closed tsheaff closed 1 year ago

tsheaff commented 1 year ago

Simply pass it along to the ReactNative Modal element (docs here). Takes the same type, 'none' | 'slide' | 'fade'. Defaults to none to keep the existing behavior consistent.

tsheaff commented 1 year ago

@hossein-zare thoughts on this? Really simple addition, and preserves the default behavior for everyone.

I'm installing my fork for now to get this behavior, will switch back to the main project once this is included in a published version.

hossein-zare commented 1 year ago

Mergeable, Thanks.

tsheaff commented 1 year ago

Thanks @hossein-zare

When will this be available in a public npm release?

hossein-zare commented 1 year ago

I think next week.

tsheaff commented 1 year ago

@hossein-zare any update on the next release?

hossein-zare commented 1 year ago

v5.4.4 is out.