feat: Add customItemValueDelimiter

hossein-zare / react-native-dropdown-picker

A single / multiple, categorizable, customizable, localizable and searchable item picker (drop-down) component for react native which supports both Android & iOS.

https://hossein-zare.github.io/react-native-dropdown-picker-website/

MIT License

970 stars 294 forks source link

feat: Add customItemValueDelimiter #670

Open JHeigle opened 1 year ago

JHeigle commented 1 year ago

Hey @hossein-zare, saw a potential small issue with the custom item value .replace() modifier for spaces. This update will allow users to customize the delimiter for the value saved when selecting a custom item and make sure that the delimiter is implemented in all space instances.

The value for the customItemValueDelimiter defaults to what was already in place (-).
.replace() was replaced (no pun intended) with .replaceAll().

Thank you for your feedback!

jacklj commented 11 months ago

This is great, thanks, could it be merged please?

joshzeldin commented 6 months ago

This is great and helps solve the issue I was having #604

I was looking into this same thing and was struggling to figure out why the space to dash replacement was necessary at all. Do you know what the purpose of the replacement is? For my use, I'd like to maintain the spaces in my items, but I'm not sure if this is going to break the library?