hossein-zare / react-native-dropdown-picker

A single / multiple, categorizable, customizable, localizable and searchable item picker (drop-down) component for react native which supports both Android & iOS.
https://hossein-zare.github.io/react-native-dropdown-picker-website/
MIT License
970 stars 294 forks source link

remove unneeded error; add license badge and usage info to readme #702

Closed taeh98 closed 10 months ago

taeh98 commented 10 months ago
hossein-zare commented 10 months ago

Hey @taeh98 Where can we talk about this issue, https://github.com/hossein-zare/react-native-dropdown-picker/issues/668

taeh98 commented 10 months ago

Hey @taeh98 Where can we talk about this issue, #668

Hi @hossein-zare, hope you're good. I'm currently working on #641 since I had the same issue. I just found the docs on usage with class components, so I'm trying to see if following them solves the issue for me right now.

What needs to happen with #668? Just making the same changes that guy did in a PR?

hossein-zare commented 10 months ago

Thanks.

I've already fixed the bug (not sure) months ago. Could you please apply @jobrdelivery 's solution to your project (not the repository) and tell me if it's bug-free and works as expected? You can also install 5.4.7-beta.1 instead.

taeh98 commented 10 months ago

Thanks.

I've already fixed the bug (not sure) months ago. Could you please apply @jobrdelivery 's solution to your project (not the repository) and tell me if it's bug-free and works as expected? You can also install 5.4.7-beta.1 instead.

No problem!

You fixed #641 months ago? I'm just trying to make it work per the docs at the moment.

And yes, I'll test it out at some point and let you know - I have to get my project working first anyway because it broke from v4 to v5 with #641.

hossein-zare commented 10 months ago

I fixed #668 Let me know if it's buggy with class components.