hosseinmoein / DataFrame

C++ DataFrame for statistical, Financial, and ML analysis -- in modern C++ using native types and contiguous memory storage
https://hosseinmoein.github.io/DataFrame/
BSD 3-Clause "New" or "Revised" License
2.54k stars 313 forks source link

CMake: prefer compile feature to set at least C++17 #156

Closed SpaceIm closed 2 years ago

SpaceIm commented 2 years ago

Good practice in a C++ library is to use target_compile_feature() to set minimum C++ standard, in order to not constrain a specific maximum standard like CXX_STANDARD does.

I've also removed PIC. In CMake, PIC comes for free in shared lib. For static lib, it's a user decision, so it's better to keep default behavior (principle of least surprise).