DateTime: Definition of templated function member date_to_str is not in the header

hosseinmoein / DataFrame

C++ DataFrame for statistical, Financial, and ML analysis -- in modern C++ using native types and contiguous memory storage

https://hosseinmoein.github.io/DataFrame/

BSD 3-Clause "New" or "Revised" License

2.54k stars 313 forks source link

Closed SpaceIm closed 2 years ago

SpaceIm commented 2 years ago

It doesn't fail when DataFrame & tests are compiled because date_to_str() is used only in DateTime.cc compilation unit where it is also defined.

However, date_to_str() is publicly exposed in DateTime header, but it can't work in any other context than DateTime.cc compilation.

It should probably be removed, and its definition moved to string_format() in DateTime.cc, which is the only user of this function.

hosseinmoein commented 2 years ago

This has been fixed in master Thx