Plausibility of adapting for C++17 in a fork?

hosseinmoein / DataFrame

C++ DataFrame for statistical, Financial, and ML analysis -- in modern C++ using native types and contiguous memory storage

https://hosseinmoein.github.io/DataFrame/

BSD 3-Clause "New" or "Revised" License

2.41k stars 306 forks source link

Plausibility of adapting for C++17 in a fork? #244

Closed joshcol9232 closed 1 year ago

joshcol9232 commented 1 year ago

Hi! I'm looking to use DataFrame within a system which only supports C++17. How plausible would it be to replace/remove C++20 functionality? It would be undertaken by me or another one of my colleagues in a fork, or here if so desired. Thanks

hosseinmoein commented 1 year ago

It shouldn't be that bad. You have to remove the [[likely]], ... attributes which is trivial. Also, I use concepts that you have to remove. That maybe a little more involved. Other than that, I don't remember any other dependency on C++20

joshcol9232 commented 1 year ago

Thanks for the quick response. Great, good to know :). I'll close this for now