search

hosseinmoein / DataFrame

C++ DataFrame for statistical, Financial, and ML analysis -- in modern C++ using native types and contiguous memory storage
https://hosseinmoein.github.io/DataFrame/
BSD 3-Clause "New" or "Revised" License
2.38k stars 298 forks source link

test failed #269

Closed ludeen007 closed 7 months ago

ludeen007 commented 8 months ago

Thanks for this excellent project! I run a test that failed. I install DataFrame with vcpkg, try it on VS2022 17.8.1, with x64 Debug build settings. Then I encountered a assert failed. file test/dataframe_tester_2.cc, line 400: assert(result[10] == static_cast(-1)); after debug, I change that line as below to fix: assert(result[10] == static_cast(-1));

hosseinmoein commented 8 months ago

I think you had a problem in your copy/past. I don't see a difference in what it was and what you say it should be

ludeen007 commented 7 months ago

Sorry for my mistake. Turns out that I should learn more about markdown syntax. Here's what I want to say: I ran a test that failed. I installed DataFrame with vcpkg, tried it on VS2022 17.8.1, with x64 Debug build settings. Then I encountered a assert failed. file test/dataframe_tester_2.cc, line 400: assert(result[10] == static_cast\<unsigned long>(-1)); after debug, I changed that line as below to fix: assert(result[10] == static_cast\<unsigned long long>(-1));