search

hosseinmoein / DataFrame

C++ DataFrame for statistical, Financial, and ML analysis -- in modern C++ using native types and contiguous memory storage
https://hosseinmoein.github.io/DataFrame/
BSD 3-Clause "New" or "Revised" License
2.53k stars 314 forks source link

INTERFACE_LINK_LIBRARY is missing `tbb` #290

Closed avilleret closed 7 months ago

avilleret commented 8 months ago

On Linux, to link my program against DataFrame fd56c03 with CMake, I have to add tbb in the link libraries list, i.e.: 

target_link_libraries(database_processor DataFrame::DataFrame tbb)

I think this should come from DataFrame::DataFrame itself thanks to INTERFACE_LINK_LIBRARIES

I'm pretty sure tbb could be added around this line https://github.com/hosseinmoein/DataFrame/blob/master/CMakeLists.txt#L69 but I'm not sure in which case it is required.

hosseinmoein commented 8 months ago

That's a very specific requirement. I am not a cmake guru. If you know a way to make this a clean option in compiling, please send me a PR.