Fix some cpp warnings - Githubissues

hosseinmoein / DataFrame

C++ DataFrame for statistical, Financial, and ML analysis -- in modern C++ using native types and contiguous memory storage

https://hosseinmoein.github.io/DataFrame/

BSD 3-Clause "New" or "Revised" License

2.38k stars 298 forks source link

Fix some cpp warnings #298

Closed andersc closed 3 months ago

andersc commented 3 months ago

There are still warnings to fix but this commit fixes some.

For example -> DataFrameMLVisitors.h still contains a lot of locally shadowed variables.

andersc commented 3 months ago

Linux is not building.. Need to check why.

andersc commented 3 months ago

ba4293f fixes the linux build.

hosseinmoein commented 3 months ago

There are still warnings to fix but this commit fixes some.

For example -> DataFrameMLVisitors.h still contains a lot of locally shadowed variables.

I don't have access to many environments, just macos and Ubuntu in virtual machine. So thanks for fixing all warnings. Let me know when this is ready to merge

andersc commented 3 months ago

If it's OK by you then you can squash and merge as it is right now. All major warnings has been fixed. There are some casts in 'DateTime.cc' marked TODO that I will look into but probably after talking to you first if you're not looking into them yourself.