hosseinmoein / DataFrame

C++ DataFrame for statistical, Financial, and ML analysis -- in modern C++ using native types and contiguous memory storage
https://hosseinmoein.github.io/DataFrame/
BSD 3-Clause "New" or "Revised" License
2.53k stars 313 forks source link

The README benchmark is strongly out-of-date #332

Closed adrian17 closed 3 weeks ago

adrian17 commented 1 month ago

From what I see, the last time the benchmark files or results were updated was 10 months ago. Surely all three compared libraries could have significantly changed since then.

Also, polars now shows a deprecation warning:

polars_performance.py:33: DeprecationWarning: `pl.count()` is deprecated. Please use `pl.len()` instead.
  print(f"Number of rows after select: {df3.select(pl.count()).item()}")
hosseinmoein commented 1 month ago

I will take a look, thanks

hosseinmoein commented 4 weeks ago

Running the benchmarks and its supporting processes takes me a few hours. I will find some time in the future to rerun them. In the meantime, in the README, I note exactly the versions of all packages used. So there should be no confusion as to what I am comparing against what.