search

hosseinmoein / DataFrame

C++ DataFrame for statistical, Financial, and ML analysis -- in modern C++ using native types and contiguous memory storage
https://hosseinmoein.github.io/DataFrame/
BSD 3-Clause "New" or "Revised" License
2.54k stars 313 forks source link

Question of HeteroPtrView Constructor #78

Closed nehcuh closed 4 years ago

nehcuh commented 4 years ago

Hi Hosseinmoein,

When I'm reading your excellent code, I've got confused of your use of unordered_map.

In your code include/DataFrame/Vectors/HeteroPtrView.h, you've set a private member which I quote here template<typename T> inline static std::unordered_map<const HeteroPtrView *, VectorPtrView<T>> views_ { };.

Then in include/DataFrame/Vectors/HeteroPtrView.tcc, the constructor method

template <typename T> HeteroPtrView::HeteroPtrView(VectorPtrView<T>& vec),

you've used a push_back method which unordered_map unsupported, is there something wrong?

HeteroPtrView.h

01

HeteroPtrView.tcc

02
hosseinmoein commented 4 years ago

You are right. I will fix it. I guess this constructor was never used any where. That's why I never noticed it Thanks