hossimo / CITP-Dissector

Wireshark CITP Lua Disector
http://hossimo.github.com/CITP-Dissector/
11 stars 7 forks source link

MSEX v1.2 additions #7

Closed MrRoundRobin closed 8 years ago

MrRoundRobin commented 8 years ago
hossimo commented 8 years ago

Thanks for the PR, looks good though it's been some time since I looked at this code and I need some testing with MSEX 1.2. May I ask what you are testing with?

MrRoundRobin commented 8 years ago

currently i made the changes only according to the specification

i want to add full 1.2 support because of an other project where i want to add CITP to an media server communicating with grandMA2 on PC

MrRoundRobin commented 8 years ago

that's right, ugly copy & past error...

i thought about the "flag handling", and found out that this could look nicer if if you use ProtoFields.

i created a seperat branch and changed all fields to ProtoField. thats a big change, but with that you can also filter on each field. if you like, i can create a pull request from that branch