search

hostnet / form-handler-bundle

Provide an easier way of handling forms in actions
MIT License
71 stars 15 forks source link

Remove 5.6 travis builds. #60

Closed mvannes closed 5 years ago

mvannes commented 5 years ago

5.6 Travis jobs are failing on composer installation with the following error message:

symfony/browser-kit v4.1.6 requires php ^7.1.3 -> your PHP version (5.6.32) does not satisfy that requirement.

Proposed solution is to not run builds for PHP version 5.6 as our other dependencies have outgrown this PHP version.

mvannes commented 5 years ago

Should probably do that stuff in a different commit though, unrelated to this. But yes, starting 7.2 seems like a good idea to me!

ping-localhost commented 5 years ago

Yes, please create a new PR for that. :wink:

yannickl88 commented 5 years ago

5.6 is still a version we support so it should still run in travis. If the builds fail we might be better of with adjusting the composer requirements.

mvannes commented 5 years ago

Nope, we still want to provide support for 5.6. We discussed this internally, and it should still be possible to resolve this the other way around by adding more to the composer.json for symfony/browser-kit