Publishing automation - start

hot-loader / react-dom

🔥 version of React-DOM

110 stars 11 forks source link

Publishing automation - start #10

Closed Bnaya closed 5 years ago

Bnaya commented 5 years ago

Code is still plain js, but fully covered by typescript via jsdocs
Refactor code to be more programatic
Added utils function that can check if we need to build & publish new version
Added dummy circleci file
Some vscode configs

implements : https://github.com/hot-loader/react-dom/issues/9

Bnaya commented 5 years ago

@theKashey I would like your preliminary opinion regarding my work code styles, infra decisions, etc The most interesting part is auto-publish/utils.js

I've also sent you a request from circleci to give me access to add this project there, And then i will start playing with the periodic stuff (That will basically run the code we have here)

theKashey commented 5 years ago

I'll port RHL+react-dom integration test to verify the result. Even if RHL is testing patch+react-dom - it does in it a separate loop, and integration might break with react-dom update.

Bnaya commented 5 years ago

it has manual approval. super cool. https://circleci.com/docs/2.0/triggers/#manual-approval

Bnaya commented 5 years ago

@theKashey friendly ping :)

theKashey commented 5 years ago

Ouch. Pinging on weekends not always work well :)

Bnaya commented 5 years ago

I'm SORRY! I'm from Israel and i forgot its still your weekend :(

Bnaya commented 5 years ago

So what's next?