React v16.10 is out - Githubissues

hot-loader / react-dom

🔥 version of React-DOM

110 stars 11 forks source link

Closed Kerumen closed 4 years ago

Kerumen commented 5 years ago

Bnaya commented 5 years ago

The patches got broken again Need to re do them

theKashey commented 5 years ago

RHL 4.12.15 released. We could process with react-dom

Bnaya commented 5 years ago

Go for it :) I don't have publish permissions ;)

theKashey commented 5 years ago

🥳 released 🥳, all kudos to @Bnaya

davidroeca commented 5 years ago

~Downloaded the latest and this is still not working with:~

{
    "@hot-loader/react-dom": "16.10.2",
    "react": "16.10.2",
    "react-dom": "16.10.2",
    "react-hot-loader": "4.12.15"
}

~Using @hot-loader/react-dom breaks everything, and switching to react-dom works in basic cases.~

Bnaya commented 5 years ago

Just tested it on freshly created & ejected CRA project, and works fine

davidroeca commented 5 years ago

Yep I think something else is going on with my setup, having trouble reproducing in a simpler case.

Bnaya commented 5 years ago

Which errors do you get?

davidroeca commented 5 years ago

No errors, just no HMR in my current setup. I actually don't think it's a problem here, but will report back if I find something.

Edit: confirming that this was an issue on my end and has nothing to do with this package.

SebastienGllmt commented 4 years ago

v16.11 is out now. Not sure if the new patch has to be made for this

theKashey commented 4 years ago

Not the patch, but a new package version - for sure.