search

hot-loader / react-dom

🔥 version of React-DOM
110 stars 11 forks source link

Don't use plus sign "+" in versioning #37

Closed Maxim-Mazurok closed 4 years ago

Maxim-Mazurok commented 4 years ago

Fixes #36

Related to d33208f02ebef963cdd3e91980b6d2a588588409 from #14

theKashey commented 4 years ago

That was made by a reason - react-dom version is not bound react-hot-loader's one, and their release cycles are not synchronized as well. By that time rhl was releasing way faster than react-dom, including some updates to the "patches" it makes to react-dom, so we needed it.

A bit more standard way is to use -, not +, but it means that something is in beta, and should not be installed unless direct command.

I am sorry, but I could not accept your PR.

Keep in mind - react-hot-loader is already in the deprecation phase, please take a look at https://github.com/pmmmwh/react-refresh-webpack-plugin

Maxim-Mazurok commented 4 years ago

I see, thank you for explaining.

Since it's in the deprecation state, probably there's no reason to come up with alternative solution.